From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 893681FF15C for ; Fri, 19 Sep 2025 10:41:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 47CD6109FD; Fri, 19 Sep 2025 10:41:49 +0200 (CEST) Message-ID: <91adf303-d6df-4701-9ccf-58476691d9e9@proxmox.com> Date: Fri, 19 Sep 2025 10:41:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Stoiko Ivanov References: <20250918142052.131956-1-f.ebner@proxmox.com> <20250918142052.131956-4-f.ebner@proxmox.com> <20250918225832.10aa59bf@rosa.proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250918225832.10aa59bf@rosa.proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758271295724 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pmg-devel] [PATCH pmg-api 3/4] partially fix #2077: pmgsh: remove dependency on Term::ReadLine X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmg-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" Am 18.09.25 um 10:58 PM schrieb Stoiko Ivanov: > Thanks for tackling this! > > applied the patch for pve-common and played around a bit with pmgsh - and > yes - I did miss the completion (not the history though.. and am not sure > if I overlooked some other readline feature that would be lost) > > but this reminded me of pvesh and that we dropped interactive mode at some > point (around PVE 5.2) there: > https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=cfc6a662938b90069e6c70b8112021a4554bad27 > and the rationale of using bash for completion (still) sounds sensible. Oh, that dropped the REPL-style interface completely. If we do want to go ahead with dropping Term::ReadLine for pmgsh, I think we should do that here too. > did not look closer at what pmgsh is still missing from pvesh (the latter > saw quite a bit more changes in the past years) - but currently this seems > to be a good alternative. > (I'm not sure if I'll get to checking this in the upcoming 1-2 weeks, but > could try if you are busy elsewhere and noone else steps up) Do you have an example for what (potential) features you have in mind here? Or just looking through all pvesh changes and see what would be nice to have for pmgsh too? > FWIW - tried registering an acme account (patch 1/4) - also worked fine. Would you mind adding a T-b there :)? _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel