From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CC379856E for ; Tue, 15 Nov 2022 15:32:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B4DF64EF9 for ; Tue, 15 Nov 2022 15:32:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 15 Nov 2022 15:32:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F0C9044C79 for ; Tue, 15 Nov 2022 15:32:46 +0100 (CET) Message-ID: <916175b1-4cdc-0ab2-747a-3be588154aec@proxmox.com> Date: Tue, 15 Nov 2022 15:32:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20221109182728.629576-1-s.ivanov@proxmox.com> <20221109182728.629576-3-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221109182728.629576-3-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.032 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF =?UTF-8?Q?record=0A=09?=URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [reportspam.pm, ruledb.pm, attach.pm, counter.pm] Subject: [pmg-devel] applied: [PATCH pmg-api 2/5] ruledb: add deprecation warnings for unused actions X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2022 14:32:47 -0000 Am 09/11/2022 um 19:27 schrieb Stoiko Ivanov: > * ReportSpam > * Attach > * Counter > > are all still present since (at least) the release of PMG 5.0, but > were never exposed in the API/GUI. > > All of them in their current form don't seem to fit well nowadays, or > their functionality was taken over by some other Action: > * Attach - the functionality is currently present in the Notify action > (attach original mail) > * Counter - without a matching What object simply increasing a counter > by one in the database serves no purpose > * ReportSpam - sending potentially sensitive mail automatically to the > public SpamAssassin project does not seem to fit well nowadays > > Instead of dropping them right away - this patch adds logging when > they are encountered while loading or when they are run, to keep > backwards-compatibility for users who have very long-running PMG > instances (not sure if the actions were ever used in the pre git-days > of PMG) > > Signed-off-by: Stoiko Ivanov > --- > src/PMG/RuleDB.pm | 14 +++++++++++++- > src/PMG/RuleDB/Attach.pm | 7 +++++++ > src/PMG/RuleDB/Counter.pm | 5 +++++ > src/PMG/RuleDB/ReportSpam.pm | 5 +++++ > 4 files changed, 30 insertions(+), 1 deletion(-) > > applied, thanks!