From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 54744936A1 for ; Tue, 20 Feb 2024 10:37:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 347F93B63 for ; Tue, 20 Feb 2024 10:37:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 20 Feb 2024 10:37:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EA52A43B77 for ; Tue, 20 Feb 2024 10:37:57 +0100 (CET) Message-ID: <8ebdf6fa-4d30-45d8-a002-334eaf54c471@proxmox.com> Date: Tue, 20 Feb 2024 10:37:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pmg-devel@lists.proxmox.com References: <20240219175548.311288-1-m.limbeck@proxmox.com> From: Mira Limbeck In-Reply-To: <20240219175548.311288-1-m.limbeck@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.260 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [PATCH v2 pmg-log-tracker 1/5] rfc3339: move timezone offset compatibility code to old time parser X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2024 09:37:59 -0000 > @@ -1787,7 +1787,11 @@ impl Parser { > line, > self.current_year, > self.current_month, > - self.timezone_offset, > + // use start time for timezone offset in parse_time_no_year rather than the > + // timezone offset of the current time > + // this is required for cases where current time is in standard time, while start > + // time is in summer time or the other way around > + self.start_tm.tm_gmtoff, > ) { forgot to change this when checking the files if they're within the start and end time. after changing this, we can get rid of the timezone_offset member in the parser completely. I'll send a v3 with this change