From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pmg-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 249D01FF16E for <inbox@lore.proxmox.com>; Mon, 17 Feb 2025 14:26:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C1BF01FEDA; Mon, 17 Feb 2025 14:26:44 +0100 (CET) Message-ID: <8c507270-8e86-4a71-bff3-5989b94997fe@proxmox.com> Date: Mon, 17 Feb 2025 14:26:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com References: <20250130123350.50043-1-s.ivanov@proxmox.com> <20250130123350.50043-3-s.ivanov@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <20250130123350.50043-3-s.ivanov@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api 2/2] pmg7to8: add check for deprecated default entries in ruledb X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com> On 1/30/25 13:33, Stoiko Ivanov wrote: > with a new section for future checks of the rule database. > > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> > --- > src/PMG/CLI/pmg7to8.pm | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/src/PMG/CLI/pmg7to8.pm b/src/PMG/CLI/pmg7to8.pm > index d0a6cbe..4e11b6b 100644 > --- a/src/PMG/CLI/pmg7to8.pm > +++ b/src/PMG/CLI/pmg7to8.pm > @@ -13,6 +13,7 @@ use PMG::API2::APT; > use PMG::API2::Certificates; > use PMG::API2::Cluster; > use PMG::RESTEnvironment; > +use PMG::RuleDB; > use PMG::Utils; > > use Term::ANSIColor; > @@ -526,6 +527,23 @@ sub check_dkms_modules { > } > } > > +sub check_ruledb { > + log_info("Check the rulesystem..."); > + > + my $rdb = PMG::RuleDB->new(); > + my $ogroups = $rdb->load_objectgroups("who"); > + for my $who ($ogroups->@*) { > + my $group_name = $who->{name}; > + next if ($group_name ne 'Blacklist' && $group_name ne 'Whitelist'); > + my $objects = $rdb->load_group_objects($who->{id}); > + for my $obj ($objects->@*) { > + log_warn("deprecated default entry in '$group_name' present: $obj->{address}") > + if ($obj->{address} =~ m/(?:no)?mail\@fromthisdomain.com/); I'd like here an additional sentence to the user what can be done, e.g. 'consider removing the rule' or something like that. When having such a migration/upgrade tool, we should always provide instructions on what to do when something is off. > + } > + } > + return; > +} > + > sub check_misc { > print_header("MISCELLANEOUS CHECKS"); > my $ssh_config = eval { PVE::Tools::file_get_contents('/root/.ssh/config') }; > @@ -637,6 +655,7 @@ __PACKAGE__->register_method ({ > code => sub { > my ($param) = @_; > > + check_ruledb(); > check_pmg_packages(); > check_cluster_status(); > my $upgraded_db = check_running_postgres(); _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel