From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmg-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 434E71FF16F
	for <inbox@lore.proxmox.com>; Thu, 27 Feb 2025 12:06:55 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id C58832FF47;
	Thu, 27 Feb 2025 12:06:53 +0100 (CET)
Message-ID: <81d50cb6-1211-4e3f-8178-21944b3ee146@proxmox.com>
Date: Thu, 27 Feb 2025 12:06:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: pmg-devel@lists.proxmox.com
References: <20250227110439.660459-1-s.ivanov@proxmox.com>
Content-Language: en-US
From: Mira Limbeck <m.limbeck@proxmox.com>
In-Reply-To: <20250227110439.660459-1-s.ivanov@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.311 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pmg-devel] [PATCH pmg-api] oidc: realm: only autocreate users
 on primary cluster-node
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
 <pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pmg-devel-bounces@lists.proxmox.com
Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com>

On 2/27/25 12:04, Stoiko Ivanov wrote:
> PMG::RESTEnvironment->check_node_is_master() dies if called on a
> secondary node.
> It is called in an eval that results in a sensible error-message being
> presented to the user.
> 
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  src/PMG/API2/OIDC.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/PMG/API2/OIDC.pm b/src/PMG/API2/OIDC.pm
> index 2d016f6..c256014 100644
> --- a/src/PMG/API2/OIDC.pm
> +++ b/src/PMG/API2/OIDC.pm
> @@ -192,6 +192,7 @@ __PACKAGE__->register_method ({
>  	    # first, check if $username respects our naming conventions
>  	    PMG::Utils::verify_username($username);
>  	    if ($config->{'autocreate'} && !$rpcenv->check_user_exist($username, 1)) {
> +		$rpcenv->check_node_is_master();
>  		my $code = sub {
>  		    my $usercfg = PMG::UserConfig->new();
>  

Gave the patch a quick try. Secondary node login no longer works.
Login on primary gives the error that no such user exists on the
secondary node until it has synced.

Tested-by: Mira Limbeck <m.limbeck@proxmox.com>


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel