From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1D3231FF146 for ; Tue, 09 Jun 2026 00:43:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B80343731D; Tue, 9 Jun 2026 00:43:51 +0200 (CEST) Message-ID: <7c71b094-aa22-43d7-836f-c81331846f02@proxmox.com> Date: Tue, 9 Jun 2026 00:43:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pmg-gui] spam quarantine: reorganize buttons To: Dominik Csapak , pmg-devel@lists.proxmox.com References: <20260608121725.2417034-1-d.csapak@proxmox.com> Content-Language: en-US, de-DE From: Thomas Lamprecht In-Reply-To: <20260608121725.2417034-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780958554356 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VKBCT3ZSG3YNZZBLM6VI663VXWKOSHPM X-Message-ID-Hash: VKBCT3ZSG3YNZZBLM6VI663VXWKOSHPM X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 08/06/2026 14:16, Dominik Csapak wrote: > Since the number of buttons is rather large now, move the > 'non-essential' actions into a 'More' menu. With this, there less often > the need for it to be scrollable. > > Since the download button handled the download via the 'href' and > 'download' attribute, this needs to be adapted to a proper handler and > handle it like we downloads in other places. Could be potentially a little bit nicer to only do this if there is not enough space, e.g. simply using a fixed width boundary with some head-room as check. As I could imagine that some users will use the blocklisting much more often than mark-seen, potentially depending also on the mailbox in question. Alternatively, or additionally: As download is rather a obvious icon we could also drop the label there and add a tooltip instead to save some space while keeping that (IMO rather relevant) function available.