From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 967B86993C for ; Thu, 11 Mar 2021 16:28:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 805C82AFC6 for ; Thu, 11 Mar 2021 16:27:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0DAB62AFB9 for ; Thu, 11 Mar 2021 16:27:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C76A2463A3 for ; Thu, 11 Mar 2021 16:27:31 +0100 (CET) Message-ID: <6539a87d-d485-cd41-d308-fe96c2f74d73@proxmox.com> Date: Thu, 11 Mar 2021 16:27:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Thunderbird/87.0 Content-Language: en-US To: Dominik Csapak , pmg-devel@lists.proxmox.com References: <20210309141401.19237-1-w.bumiller@proxmox.com> <20210309141401.19237-16-w.bumiller@proxmox.com> <8b932c18-b9b5-b91d-7633-674151ab4042@proxmox.com> <59743fec-2b1a-4920-838d-bc969616011b@proxmox.com> From: Thomas Lamprecht In-Reply-To: <59743fec-2b1a-4920-838d-bc969616011b@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.048 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH widget-toolkit 5/7] add ACME account panel X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 15:28:02 -0000 On 11.03.21 16:16, Dominik Csapak wrote: > > > On 3/11/21 4:14 PM, Thomas Lamprecht wrote: >> On 11.03.21 14:51, Dominik Csapak wrote: >>> high level question/remark: >>> >>> would it not be nicer if we set the acmeUrl >>> in Proxmox.Utils to e.g., /config/acme >>> and overwrite that in pve ? (like >>> we do with task descriptions?) >>> >>> this way the caller does not have to concern >>> itself with the url and we only set it one time per product >>> >> I like the idea in general, but the Utils class are quite overused/crowded >> already, and this is rather not a Util but a config, maybe a Proxmox.Config >> class could be added and used? >> > yeah, or maybe we could have a general 'Proxmox.APIPaths' class that contains the paths for wt relevant stuff? so that we do not have > to design the api of new products in such a way that all products > are the same (e.g. /nodes/YYY/ stuff) IMO that would be a object of Proxmox.Config, avoiding to many top level classes which are all would fit in the "product specific properties/configs/api-paths" category. Just as example, something like Ext.define('Proxmox.Cfg', { APIPaths: { host_disk: { get: ..., put: ...., } }, // possible other stuff }); But yeah, I'd like to avoid repeating what we did in PBS with starting out with /api2/ as prefix, that feels a bit weird.