From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 21CA26BD2B for ; Thu, 18 Mar 2021 17:04:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 153351B986 for ; Thu, 18 Mar 2021 17:04:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id F31AC1B976 for ; Thu, 18 Mar 2021 17:04:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 91F0546359 for ; Thu, 18 Mar 2021 17:04:11 +0100 (CET) Message-ID: <63d64b1b-be33-cdd6-1f71-8f6fedf5554e@proxmox.com> Date: Thu, 18 Mar 2021 17:04:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Thunderbird/87.0 Content-Language: en-US To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20210318151449.18638-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210318151449.18638-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [acme.pm, certificates.pm, cluster.pm] Subject: [pmg-devel] applied: [PATCH pmg-api 0/4] cosmetic and minor improvements to certificate integration X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Mar 2021 16:04:13 -0000 On 18.03.21 16:14, Stoiko Ivanov wrote: > while trying the new acme integration on our internal system, we noticed 3 > small glitches: > * /etc/pmg/acme/accounts could not get created (since it's parent dir did > not exist) (patches 1,2) > * cluster fingerprint update failed when running on master-node (patch 3) > * postfix did not load the new pmg-tls.pem after the successful task (patch > 4) > > all tested on my test-installs > > Stoiko Ivanov (4): > package: ship /etc/pmg/acme/accounts in deb > acme: recursively create account directory > cluster: use old and new fingerprint on master > certs: reload postfix to activate new certificate > > debian/dirs | 1 + > src/PMG/API2/ACME.pm | 4 +++- > src/PMG/API2/Certificates.pm | 14 ++++++-------- > src/PMG/Cluster.pm | 12 ++++++------ > 4 files changed, 16 insertions(+), 15 deletions(-) > applied, thanks! Dropped a now useless variable from set_smtp, also unified make_path, mkpath and remove_tree, rmtree usages tree-wide