From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1946672B1A for ; Wed, 16 Jun 2021 13:04:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 092A810D06 for ; Wed, 16 Jun 2021 13:04:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8859310CF7 for ; Wed, 16 Jun 2021 13:04:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5033743B5D for ; Wed, 16 Jun 2021 13:04:15 +0200 (CEST) To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20210611155447.9162-1-s.ivanov@proxmox.com> From: Dominik Csapak Message-ID: <6123a046-2757-e956-b201-cd0243bee6b3@proxmox.com> Date: Wed, 16 Jun 2021 13:04:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210611155447.9162-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.969 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.095 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [dbtools.pm, cluster.pm] Subject: Re: [pmg-devel] [PATCH pmg-api 0/2] remove unused greylist table column and make test_gl more robust X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2021 11:04:16 -0000 looks good, works as advertised. did not matter if i upgraded a master node first or not (since we did not rely on the host column any more anyway) nice :) i could not reproduce the original problem of the second patch, but it did not break it, so also ok Reviewed-By: Dominik Csapak Tested-By: Dominik Csapak On 6/11/21 5:54 PM, Stoiko Ivanov wrote: > These two patches are the result from some intial trials to build and test > PMG on debian bullseye > > The first drops a deprecated database column, and since I consider changes > to the database schema somewhat sensitive I'd like another set of eyes > to look over the changes > > the second patch addresses a timing issue in test_greylist.pl, which > causes the tests to fail, because the policy daemon is not accepting > connections early enough (at least on my test-container with bullseye) > One alternative would be to skip the greylist tests here which would > enables building as non-root user. > > Stoiko Ivanov (2): > greylisting: drop unneeded Host column form cgreylist table > tests: greylist: retry connecting 3 times > > src/PMG/Cluster.pm | 3 +-- > src/PMG/DBTools.pm | 21 +++++++++++++++------ > src/bin/pmgpolicy | 6 ++---- > src/tests/test_greylist.pl | 14 ++++++++++---- > 4 files changed, 28 insertions(+), 16 deletions(-) >