From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmg-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 703491FF176
	for <inbox@lore.proxmox.com>; Fri, 21 Feb 2025 13:45:15 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 0D799ED0;
	Fri, 21 Feb 2025 13:45:14 +0100 (CET)
Date: Fri, 21 Feb 2025 13:45:09 +0100 (CET)
From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: Markus Frank <m.frank@proxmox.com>, pmg-devel@lists.proxmox.com
Message-ID: <601344354.10144.1740141909687@webmail.proxmox.com>
In-Reply-To: <20250218161905.17224-9-m.frank@proxmox.com>
References: <20250218161905.17224-1-m.frank@proxmox.com>
 <20250218161905.17224-9-m.frank@proxmox.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev73
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.045 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pmg-devel] [PATCH widget-toolkit v5 8/10] fix: window:
 AuthEditBase: rename variable 'realm' to 'type'
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
 <pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pmg-devel-bounces@lists.proxmox.com
Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com>


> Markus Frank <m.frank@proxmox.com> hat am 18.02.2025 17:19 CET geschrieben:
> 
>  
> PVE/PMG API returns a variable called 'type' instead of 'realm'
> 
> Fixes: 3822a031ddbe4136aa847476f2e3785934a41547
> Signed-off-by: Markus Frank <m.frank@proxmox.com>

this looks like an independent bug fix?

> ---
>  src/window/AuthEditBase.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/window/AuthEditBase.js b/src/window/AuthEditBase.js
> index 73c1fee..e044235 100644
> --- a/src/window/AuthEditBase.js
> +++ b/src/window/AuthEditBase.js
> @@ -91,9 +91,9 @@ Ext.define('Proxmox.window.AuthEditBase', {
>  		    var data = response.result.data || {};
>  		    // just to be sure (should not happen)
>  		    // only check this when the type is not in the api path
> -		    if (!me.useTypeInUrl && data.realm !== me.authType) {
> +		    if (!me.useTypeInUrl && data.type !== me.authType) {
>  			me.close();
> -			throw `got wrong auth type '${me.authType}' for realm '${data.realm}'`;
> +			throw `got wrong auth type '${me.authType}' for realm '${data.type}'`;
>  		    }
>  		    me.setValues(data);
>  		},
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel