From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BDBA769864 for ; Thu, 11 Mar 2021 16:16:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B476C2ADAB for ; Thu, 11 Mar 2021 16:16:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 536EB2AD9E for ; Thu, 11 Mar 2021 16:16:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 198674638B for ; Thu, 11 Mar 2021 16:16:47 +0100 (CET) To: Thomas Lamprecht , pmg-devel@lists.proxmox.com References: <20210309141401.19237-1-w.bumiller@proxmox.com> <20210309141401.19237-16-w.bumiller@proxmox.com> <8b932c18-b9b5-b91d-7633-674151ab4042@proxmox.com> From: Dominik Csapak Message-ID: <59743fec-2b1a-4920-838d-bc969616011b@proxmox.com> Date: Thu, 11 Mar 2021 16:16:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <8b932c18-b9b5-b91d-7633-674151ab4042@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.190 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH widget-toolkit 5/7] add ACME account panel X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 15:16:47 -0000 On 3/11/21 4:14 PM, Thomas Lamprecht wrote: > On 11.03.21 14:51, Dominik Csapak wrote: >> high level question/remark: >> >> would it not be nicer if we set the acmeUrl >> in Proxmox.Utils to e.g., /config/acme >> and overwrite that in pve ? (like >> we do with task descriptions?) >> >> this way the caller does not have to concern >> itself with the url and we only set it one time per product >> > I like the idea in general, but the Utils class are quite overused/crowded > already, and this is rather not a Util but a config, maybe a Proxmox.Config > class could be added and used? > yeah, or maybe we could have a general 'Proxmox.APIPaths' class that contains the paths for wt relevant stuff? so that we do not have to design the api of new products in such a way that all products are the same (e.g. /nodes/YYY/ stuff)