From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pmg-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EA7A81FF176 for <inbox@lore.proxmox.com>; Fri, 21 Feb 2025 13:38:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F13ED0D; Fri, 21 Feb 2025 13:38:08 +0100 (CET) Date: Fri, 21 Feb 2025 13:38:03 +0100 (CET) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com> To: Markus Frank <m.frank@proxmox.com>, pmg-devel@lists.proxmox.com Message-ID: <55593164.10120.1740141483181@webmail.proxmox.com> In-Reply-To: <20250218161905.17224-6-m.frank@proxmox.com> References: <20250218161905.17224-1-m.frank@proxmox.com> <20250218161905.17224-6-m.frank@proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev73 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api v5 5/10] config: add oidc type realm X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com> > Markus Frank <m.frank@proxmox.com> hat am 18.02.2025 17:19 CET geschrieben: > > > If the autocreate option is enabled, the user is automatically created > with the Audit role. To change the role for automatically created users, > set the autocreate-role option to the preferred role. > > Signed-off-by: Markus Frank <m.frank@proxmox.com> > --- > src/Makefile | 1 + > src/PMG/AccessControl.pm | 2 + > src/PMG/Auth/OIDC.pm | 95 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 98 insertions(+) > create mode 100755 src/PMG/Auth/OIDC.pm > > diff --git a/src/Makefile b/src/Makefile > index 659a666..3cae7c7 100644 > --- a/src/Makefile > +++ b/src/Makefile > @@ -169,6 +169,7 @@ LIBSOURCES = \ > PMG/Auth/Plugin.pm \ > PMG/Auth/PAM.pm \ > PMG/Auth/PMG.pm \ > + PMG/Auth/OIDC.pm \ > > SOURCES = ${LIBSOURCES} ${CLI_BINARIES} ${TEMPLATES_FILES} ${CONF_MANS} ${CLI_MANS} ${SERVICE_MANS} ${SERVICE_UNITS} ${TIMER_UNITS} pmg-sources.list pmg-initramfs.conf > > diff --git a/src/PMG/AccessControl.pm b/src/PMG/AccessControl.pm > index ced5f9a..75ef486 100644 > --- a/src/PMG/AccessControl.pm > +++ b/src/PMG/AccessControl.pm > @@ -14,9 +14,11 @@ use PMG::LDAPSet; > use PMG::TFAConfig; > > use PMG::Auth::Plugin; > +use PMG::Auth::OIDC; > use PMG::Auth::PAM; > use PMG::Auth::PMG; > > +PMG::Auth::OIDC->register(); > PMG::Auth::PAM->register(); > PMG::Auth::PMG->register(); > PMG::Auth::Plugin->init(); > diff --git a/src/PMG/Auth/OIDC.pm b/src/PMG/Auth/OIDC.pm > new file mode 100755 > index 0000000..0acde7d > --- /dev/null > +++ b/src/PMG/Auth/OIDC.pm > @@ -0,0 +1,95 @@ > +package PMG::Auth::OIDC; > + > +use strict; > +use warnings; > + > +use PVE::Tools; > +use PMG::Auth::Plugin; > + > +use base qw(PMG::Auth::Plugin); > + > +sub type { > + return 'oidc'; > +} > + > +sub properties { > + return { > + 'issuer-url' => { > + description => "OpenID Connect Issuer Url", > + type => 'string', > + maxLength => 256, copied from PVE, I know - but can we please have proper formats and not add *more* unrestricted string types? we should rather start too restrictive and then lift restrictions based on real world use cases, the opposite is hard to impossible.. > + }, > + 'client-id' => { > + description => "OpenID Connect Client ID", > + type => 'string', > + maxLength => 256, > + }, > + 'client-key' => { > + description => "OpenID Connect Client Key", > + type => 'string', > + optional => 1, > + maxLength => 256, > + }, > + autocreate => { > + description => "Automatically create users if they do not exist.", > + optional => 1, > + type => 'boolean', > + default => 0, > + }, > + 'autocreate-role' => { > + description => "Automatically create users with a specific role.", > + type => 'string', > + enum => ['admin', 'qmanager', 'audit', 'helpdesk'], > + optional => 1, > + }, > + 'username-claim' => { > + description => "OpenID Connect claim used to generate the unique username.", > + type => 'string', > + optional => 1, > + }, > + prompt => { > + description => "Specifies whether the Authorization Server prompts the End-User for" > + ." reauthentication and consent.", > + type => 'string', > + pattern => '(?:none|login|consent|select_account|\S+)', # \S+ is the extension variant > + optional => 1, > + }, > + scopes => { > + description => "Specifies the scopes (user details) that should be authorized and" > + ." returned, for example 'email' or 'profile'.", > + type => 'string', # format => 'some-safe-id-list', # FIXME: TODO > + default => "email profile", > + optional => 1, > + }, > + 'acr-values' => { > + description => "Specifies the Authentication Context Class Reference values that the" > + ."Authorization Server is being requested to use for the Auth Request.", > + type => 'string', # format => 'some-safe-id-list', # FIXME: TODO > + optional => 1, > + }, > + }; > +} > + > +sub options { > + return { > + 'issuer-url' => {}, > + 'client-id' => {}, > + 'client-key' => { optional => 1 }, > + autocreate => { optional => 1 }, > + 'autocreate-role' => { optional => 1 }, > + 'username-claim' => { optional => 1, fixed => 1 }, > + prompt => { optional => 1 }, > + scopes => { optional => 1 }, > + 'acr-values' => { optional => 1 }, > + default => { optional => 1 }, > + comment => { optional => 1 }, > + }; > +} > + > +sub authenticate_user { > + my ($class, $config, $realm, $username, $password) = @_; > + > + die "OpenID Connect realm does not allow password verification.\n"; > +} this is dead code (but it should be called, see my other comments ;)) > + > +1; > -- > 2.39.5 > > > > _______________________________________________ > pmg-devel mailing list > pmg-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel