From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1F5389FEC for ; Tue, 27 Jun 2023 11:15:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F373733606 for ; Tue, 27 Jun 2023 11:15:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 27 Jun 2023 11:15:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 49B4B4519A for ; Tue, 27 Jun 2023 11:15:57 +0200 (CEST) Message-ID: <4a44787b-ce0d-1398-6c6d-bd70f1fed392@proxmox.com> Date: Tue, 27 Jun 2023 11:15:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20230627090027.5384-1-s.ivanov@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20230627090027.5384-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.247 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.09 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, report.pm] Subject: Re: [pmg-devel] [PATCH pmg-api] report: adapt to changes in SpamAssassin dns api X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2023 09:15:58 -0000 Tested-by: Friedrich Weber Tested by manually patching my PMG 7.3. Without this patch, the PMG system report contains: # resolve www.proxmox.com NXDOMAIN With this patch applied, it contains: # resolve www.proxmox.com www.proxmox.com. 74817 IN A 212.224.123.69 On 27/06/2023 11:00, Stoiko Ivanov wrote: > SpamAssassin 4.0 changed the way it does DNS-lookups a bit (switched > to asynchronous lookups) - this broke pmg-system-report, since > we use the SpamAssassin API to check that DNS-resolution works. > The reason for this is that SA used to take only the first entry from > /etc/resolv.conf - and SA being able to do correct resolution is > critical for it to work. > > This patch fixes the incompatible use of the DNS-API, but does not > change to the asynchronous model. > > Signed-off-by: Stoiko Ivanov > --- > tested on my pmg installation - a quick verification that it works > indeed would be appreciated > > src/PMG/Report.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PMG/Report.pm b/src/PMG/Report.pm > index aeda802..027c882 100644 > --- a/src/PMG/Report.pm > +++ b/src/PMG/Report.pm > @@ -125,6 +125,7 @@ sub check_dns_resolution { > stop_at_threshold => 0, > }); > $sa->init(); > + $sa->{resolver}->load_resolver(); > > my $packet = $sa->{resolver}->send('www.proxmox.com'); > my $answer = $packet->{answer}->[0];