From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8ABE4934C7 for ; Mon, 19 Feb 2024 19:05:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 67F6234408 for ; Mon, 19 Feb 2024 19:04:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Feb 2024 19:04:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 208EC43953 for ; Mon, 19 Feb 2024 19:04:56 +0100 (CET) Message-ID: <3e646e056537758e0b96fea51d4a8826b741c498.camel@proxmox.com> From: Alexander Zeidler To: Markus Frank , pmg-devel@lists.proxmox.com Date: Mon, 19 Feb 2024 19:04:43 +0100 In-Reply-To: <20240118145532.1362939-1-m.frank@proxmox.com> References: <20240118145532.1362939-1-m.frank@proxmox.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.106 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [PATCH pmg-api v3] config: adjust max_filters calculation to reflect current memory usage X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2024 18:05:27 -0000 On Thu, 2024-01-18 at 15:55 +0100, Markus Frank wrote: > my $max_servers =3D 5; > my $servermem =3D 120; > + my $base; > my $memory =3D physical_memory(); > - my $add_servers =3D int(($memory - 512)/$servermem); > + if ($memory < 3840) { > + warn "low amount of system memory installed, recommended is 4+ GB\n" > + ."to prevent OOM kills, it is better to set max_filters manually\n"= ; > + $base =3D $memory > 1536 ? 1024 : 512; > + } else { > + $base =3D 2816; > + $servermem =3D 150; > + } > + my $add_servers =3D int(($memory - $base)/$servermem); > $max_servers +=3D $add_servers if $add_servers > 0; > $max_servers =3D 40 if $max_servers > 40; 1. Perhaps we also want to increase the current max_filters limit of 40 minus 2? 2. With the recommended 4GB setup, the patch now only returns max_filters =3D 10 instead of the previous 32 as marked in the table below. (table with temporarily removed 38-limit for the patch columns) [1] [2] [3] [4] [5] RAM *0.975=3D yet *120 left patch left 0.5 499 3 139 3 *120 139 1 998 7 158 7 *120 158 2 1996 15 196 11 *120 676 3 2995 23 235 19 *120 715 4 3993 32 153 =3D=3D> 10 *150 2493 8 7987 38 3427 37 *150 2437 16 15974 38 11414 90 *150 2474 32 31948 38 27388 197 *150 2398 64 63897 38 59337 410 *150 2397 [1] installed [2] ca. MemTotal according to /proc/meminfo, hence used for calculation [3] max_filters returned by current code [4] expected servermem used in code and table for calculation [5] (RAM * 0.975) - (max_filters * servermem)