From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 235E0F423 for ; Thu, 15 Dec 2022 12:10:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 020B367DD for ; Thu, 15 Dec 2022 12:10:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 15 Dec 2022 12:10:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7703544A84; Thu, 15 Dec 2022 12:10:02 +0100 (CET) Message-ID: <3560812a-fdf5-fb0d-f329-bf2baf94290f@proxmox.com> Date: Thu, 15 Dec 2022 12:10:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Thunderbird/108.0 Content-Language: en-US To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20221130132054.66009-1-s.ivanov@proxmox.com> From: Dominik Csapak In-Reply-To: <20221130132054.66009-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.436 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_EVIL_NUMBERS4 1 Phone Numbers used by scammers NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [rulecache.pm] Subject: Re: [pmg-devel] [PATCH pmg-api] rulecache: sort rules additionally by id X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2022 11:10:34 -0000 On 11/30/22 14:20, Stoiko Ivanov wrote: > When more rules have the same priority currently their order is not > stable - postgres returns them in a stable way, based on their last > changetime - e.g. disabling and reenabling a rule puts it in the front > of evaluation. Sortin by id (the primary key) in addition should make > rule evaluation robust to such updates > > While there is no guarantee of ordering (within the same priority) > unexpected changes in which rule fires can cause confusion (at least > it confused me quite a bit). > > Reported-by: Mira Limbeck > Signed-off-by: Stoiko Ivanov > --- > With this applied I got stable ruleaction executions across rule-changes and > pmg-smtp-filter restarts, but would appreciate some additional test > > src/PMG/RuleCache.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PMG/RuleCache.pm b/src/PMG/RuleCache.pm > index d35e9c1..ebce98e 100644 > --- a/src/PMG/RuleCache.pm > +++ b/src/PMG/RuleCache.pm > @@ -37,7 +37,7 @@ sub new { > my $sth = $dbh->prepare( > "SELECT ID, Name, Priority, Active, Direction FROM Rule " . > "where Active > 0 " . > - "ORDER BY Priority DESC"); > + "ORDER BY Priority, ID DESC"); this sadly loses the 'DESC' ordering for the priority and all rules are now loaded in the reverse order 🙃 > > $sth->execute(); >