From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5CF0F8BEE1 for ; Fri, 28 Oct 2022 11:36:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 362C019052 for ; Fri, 28 Oct 2022 11:35:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 28 Oct 2022 11:35:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6C93944C53 for ; Fri, 28 Oct 2022 11:35:44 +0200 (CEST) Message-ID: <32804fcf-845b-a8d9-0625-588b35e2e27e@proxmox.com> Date: Fri, 28 Oct 2022 11:35:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20221027191258.11594-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221027191258.11594-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] applied-series: Re: [PATCH pmg-gui v2 0/2] low-hanging improvments for the quarantine interface X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2022 09:36:15 -0000 On 27/10/2022 21:12, Stoiko Ivanov wrote: > v1->v2: > * dropped already applied patches > * changed the patches, by splitting the refactoring of the spamquarantine > in a patch of its own, and changing virus and attachmentquarantine in > the second patch (no functional change intended) - big thanks for the > suggestion @Thomas!! > > gave me also the chance to see the adaptations of the icon-colors for delivery > and delete by Thomas in action - I like it! > > original cover-letter for v1: > A few bugzilla entries ask for features in the quarantine interface that > seem quite sensible (e.g. #4137), or are already present in the (by far > more used) spamquarantine, but never made it to the others. > > This patchset contains a single small fix, and a refactoring of the > quarantine views to use the same controller. > > Would be grateful for feedback > > > Stoiko Ivanov (2): > quarantine: refactor spamquarantine controller > quarantine: use new controller for virus and attachment quarantines > > js/AttachmentQuarantine.js | 113 +++++----- > js/Makefile | 1 + > js/SpamQuarantine.js | 290 +++++++++----------------- > js/VirusQuarantine.js | 86 ++------ > js/controller/QuarantineController.js | 170 +++++++++++++++ > 5 files changed, 335 insertions(+), 325 deletions(-) > create mode 100644 js/controller/QuarantineController.js > applied series, many thanks!