From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0A6856A34C for ; Fri, 26 Feb 2021 13:52:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EEFACEC63 for ; Fri, 26 Feb 2021 13:52:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C4327EC55 for ; Fri, 26 Feb 2021 13:52:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8740741C96 for ; Fri, 26 Feb 2021 13:52:14 +0100 (CET) To: pmg-devel@lists.proxmox.com References: <20210219103147.28013-1-m.limbeck@proxmox.com> <261ad9c6-a149-f37b-a040-525bf4d37d4e@proxmox.com> <971b5023-4953-1ef4-2519-2f0069274e37@proxmox.com> From: Mira Limbeck Message-ID: <2fafa7ed-16b0-91e8-ec21-ae95a62cd637@proxmox.com> Date: Fri, 26 Feb 2021 13:52:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <971b5023-4953-1ef4-2519-2f0069274e37@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.629 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.349 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pmg-devel] [PATCH log-tracker 1/3] update tests X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 12:52:16 -0000 On 2/26/21 10:22 AM, Mira Limbeck wrote: > On 2/25/21 11:56 AM, Thomas Lamprecht wrote: >> On 19.02.21 11:31, Mira Limbeck wrote: >>> As we only have month, day and time available but not the year, we have >>> to update the tests every year. >> I'm probably just missing context but why exactly is that the case? >> > The logs only contain month, day and time of the day which we parse. > We do this based on the current date and timezone. > > So depending on the current date and the date in the logs, we either > assume it to be in the past or in the future. This results in a > different calculated CTIME then and the tests need to be updated > accordingly. Correction, we always assume it to be in the past. But without the year info we assume it is no older than 1 year. This means when the test results we check against was created before that, the CTIME does not match anymore now. > > > Stoiko and I talked about this when I sent the patch, and we probably > want to switch to logging the year as well with 7.0 so these test > updates are no longer required afterwards. > > > > _______________________________________________ > pmg-devel mailing list > pmg-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel > >