From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D296F8D046 for ; Mon, 7 Nov 2022 10:56:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BBC822906B for ; Mon, 7 Nov 2022 10:56:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 7 Nov 2022 10:56:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 34438421B3 for ; Mon, 7 Nov 2022 10:56:51 +0100 (CET) Message-ID: <2ca5ead5-06e8-2d29-517e-b942fc01b51e@proxmox.com> Date: Mon, 7 Nov 2022 10:56:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Dominik Csapak , pmg-devel@lists.proxmox.com References: <20221104150425.124194-1-d.csapak@proxmox.com> <20221104150425.124194-5-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221104150425.124194-5-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] applied: [PATCH pmg-gui 3/5] fix #4238: SpamInfoGrid: enable sorting & add colors for spam score X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2022 09:56:52 -0000 Am 04/11/2022 um 16:04 schrieb Dominik Csapak: > sorting the matching spam rules, e.g. by score, makes it easier to see > which rules have more weight in determining spam. > > Additionally, color code the scores with colors akin to the rationale > in commit: > 365f84c ("quarantines: color code deliver and delete buttons") > > (red for positive spam scores, blue for negative ones) > > and increase the font-weight for large spamscore contributing rules. > > i chose a different blue tone that is more muted than what we use in > 'info-blue' but is different from both the 'hover' color and the > 'selected' color > > Signed-off-by: Dominik Csapak > --- > while the bug mentions that colors are problematic, there are not enough > font-weights to properly convey what we want to show here, so i added > colors with the same rationale we already used for the deliver/delete > buttons > > js/SpamInfoGrid.js | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > applied, thanks! with some further gradients and a switch to monospace for the value and spam level names (unrelated to the report, so mentioning it for completeness sake)