From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8DB3581D9D for ; Fri, 26 Nov 2021 11:11:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E33B16924 for ; Fri, 26 Nov 2021 11:10:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6125116915 for ; Fri, 26 Nov 2021 11:10:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2922144136; Fri, 26 Nov 2021 11:10:50 +0100 (CET) Message-ID: <24a5a33e-20eb-5290-a808-4361cf77702c@proxmox.com> Date: Fri, 26 Nov 2021 11:10:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20211125120304.122388-1-s.ivanov@proxmox.com> From: Dominik Csapak In-Reply-To: <20211125120304.122388-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.185 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.993 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [smtp.pm, accept.pm, bcc.pm, utils.pm] Subject: Re: [pmg-devel] [PATCH pmg-api v2 0/2] fix #2795 - add DSN support X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2021 10:11:24 -0000 LGTM Tested with after/before queue with and withoud dsn (got a dsn reply everytime i expected it) Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 11/25/21 13:03, Stoiko Ivanov wrote: > v1->v2: > * incorporated Dominik's feedback - huge thanks!! > * all parameters we don't care about are ignored (as before) > * the options are not transformed into lowercase unconditionally anymore > (they contain mail-addresses, and mail-ids - which are not case-insensitive) > * split up the patch into 2 commits - since the regexes for the MAIL and > RCPT commands is more sensitive than I expected: > ** read up on allowed characters in local-parts - tried extending the regex > to parse mailboxes more correctly - failed at that > ** decided it's ok to not allow '>' in localparts (we did not do so before) > ** did quite a bit more testing thanks to that > > > Stoiko Ivanov (2): > partially fix #2795: allow for '>' in smtp parameters > fix #2795: add support for DSN > > src/PMG/RuleDB/Accept.pm | 2 +- > src/PMG/RuleDB/BCC.pm | 6 +++++- > src/PMG/SMTP.pm | 27 ++++++++++++++++++++++----- > src/PMG/Utils.pm | 19 ++++++++++++++++--- > src/bin/pmg-smtp-filter | 1 + > 5 files changed, 45 insertions(+), 10 deletions(-) >