From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D247A917C1 for ; Mon, 27 Mar 2023 13:59:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A3F0B9E24 for ; Mon, 27 Mar 2023 13:59:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 27 Mar 2023 13:59:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0023746DD6; Mon, 27 Mar 2023 13:59:26 +0200 (CEST) Message-ID: <2203c1a7-20e7-eea2-6400-a8e3675ca5bb@proxmox.com> Date: Mon, 27 Mar 2023 13:59:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Stoiko Ivanov Cc: pmg-devel@lists.proxmox.com References: <20230324133013.2862297-1-d.csapak@proxmox.com> <20230324133013.2862297-4-d.csapak@proxmox.com> <20230327133231.73cb0f14@rosa.proxmox.com> From: Dominik Csapak In-Reply-To: <20230327133231.73cb0f14@rosa.proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-docs 2/2] administration: add section for statistics X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2023 11:59:57 -0000 On 3/27/23 13:32, Stoiko Ivanov wrote: > Thanks for addressing this - This should make the experience for our users > much better, and reduce quite a few support-requests! > > In general it looks good to me and could be merged as is > > One high-level suggestion and a few nits inline (could be a follow-up as > well): > > Since Statistics is its own entry in the GUI's navigation tree - why not > have it as a dedicated chapter of the docs? (quickly tried it here - just > putting it in a file of its own, and raising the heading levels by one > (`-` -> `=`, `~` -> `-`) and including it in pmg-adminstration-guide.adoc > seems to work fine) > > It's not a strict necessity, and the docs to GUI matching is not 100% > currently either (Backup/Restore is its own chapter, but under > Configuration on the GUI for example) > > Let me know what you think (and if you'll find the time soon to address it > or if I should send the suggestions as follow-up) > thanks for the review, the inline changes all make sense and i'll send a v2 shortly as for the own chapter, it don't really have a preference here. i put it into administration as i did not have the impression that the amount of information would warrant it's own chapter. from a user perspective though, it would probably better as it's own chapter, since it's also separate in the gui as you mentioned so i'll do that in the v2