From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D82CA1FF150 for ; Mon, 06 Jul 2026 18:07:02 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9944A21453; Mon, 06 Jul 2026 18:07:02 +0200 (CEST) Date: Mon, 6 Jul 2026 18:06:27 +0200 From: Stoiko Ivanov To: "Max R. Carrara" Subject: applied: [PATCH pmg-api/pmg-docs/pmg-gui v3 0/5] tracking-center: make input-base configurable Message-ID: <20260706180627.00e2cb3a@rosa.proxmox.com> In-Reply-To: References: <20260612174145.1190233-1-s.ivanov@proxmox.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783353981080 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WGKB44DLK5CYC2742NKNKSZ4XEZUW7LV X-Message-ID-Hash: WGKB44DLK5CYC2742NKNKSZ4XEZUW7LV X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pmg-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for your feedback and efforts in testing this! applied the series with your R-b, T-b! On Mon, 22 Jun 2026 13:24:39 +0200 "Max R. Carrara" wrote: > On Fri Jun 12, 2026 at 7:40 PM CEST, Stoiko Ivanov wrote: > > v2->v3: > > * pmg-api patch 2: change the validation from a regex to a validation sub > > to sanitize the path and prevent curdir and parentdir as well as > > consecutive slashes > > > > Thanks big-time to Max for checking the series so quickly and for the > > valuable feedback and insight into SectionConfig! I decided to not > > implement some of the suggestions (as talked off-list): > > * root-only vs. root_only - as this is not a user-facing/api parameter, > > left it in snake_case to not have to quote it. > > * I left the maximal directory depth at 6, as we can very easily extend it > > if someone requests it, while restricting after having this public would > > be backwards incompatible > > * pmg currently does not have a concept of api-permissions and not > > showing/modifying elements where an user has no permissions - > > implementing this would expand the scope of this small patch series too > > much (PVE has this in access-control [0]). > > * the docs for pmg.conf get generated automatically based on the property > > descriptions - see [1]. > > > > > > [0] https://git.proxmox.com/?p=pve-access-control.git;a=blob;f=src/PVE/RPCEnvironment.pm;h=7591aa9ed414f4e70b66bc6c40cb054bd2e8231c;hb=5ccd07d9302562b73374d331b63d25b04b86766c#l178 > > [1] https://git.proxmox.com/?p=pmg-docs.git;a=blob;f=pmg-doc-generator.mk.in;h=e9253c4a84b0d545021259b68c2051b6697a11f5;hb=b3a0fb7f942001a26d2386e5d1ee47be2b9eaf0b#l51 > > v2: > > https://lore.proxmox.com/pmg-devel/DJ5IDD9OR8HE.ENMUIGWPW37U@proxmox.com/T/#t > > > > [...] > > Many thanks for the refresh and the kind words! > > Everything LGTM -- the patches look neat, and a quick smoke-test > confirmed that the new format added in patch #2 actually does validate > the provided path as expected. Specifically, tried to get it to break > and did not succeed. Nicely done! > > One thing I'd suggest for future regexes is to make use of the /x and > /xx modifiers [0], since they really help making regexes much more > readable. Definitely not an issue in this series IMO -- just wanted to > mention it, since people less familiar with Perl may have a hard time > parsing certain REs. > > Great work -- since everything's resolved and I couldn't break it, > consider: > > Tested-by: Max R. Carrara > Reviewed-by: Max R. Carrara > > [0] https://perldoc.perl.org/perlre#/x-and-/xx