From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 396341FF13A for ; Wed, 10 Jun 2026 09:40:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C21DA5191; Wed, 10 Jun 2026 09:40:47 +0200 (CEST) From: Dominik Csapak To: pmg-devel@lists.proxmox.com Subject: [PATCH pmg-api] fix missing postfix welcomelist update Date: Wed, 10 Jun 2026 09:39:16 +0200 Message-ID: <20260610074043.501612-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm] Message-ID-Hash: DIQ74XWZ2C6LZCAQNW4WRU26J7D4QQ5F X-Message-ID-Hash: DIQ74XWZ2C6LZCAQNW4WRU26J7D4QQ5F X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Similar fix as 17f17bc (config: do not shortcircuit smtp-welcomelist generation) If `$changes` is already true, 'rewrite_postfix_welcomelist' will never called. This prevented those file generation on first boot after a fresh install. Signed-off-by: Dominik Csapak --- I tested the previous fix only after rebooting the machine, not on a new installation so I missed this. This time I installed fresh (in debug mode) and injected the changes into the file after the installation finished, but before a reboot and it worked now. Sorry, I could have caught this the first time around... src/PMG/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm index f48c31d..9b22b67 100644 --- a/src/PMG/Config.pm +++ b/src/PMG/Config.pm @@ -1916,7 +1916,7 @@ sub rewrite_config_postfix { postmap_tls_policy(); postmap_tls_inbound_domains(); - $changes ||= rewrite_postfix_welcomelist($rulecache) if $rulecache; + $changes = 1 if $rulecache && rewrite_postfix_welcomelist($rulecache); # make sure aliases.db is up to date system('/usr/bin/newaliases'); -- 2.47.3