From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CB7A91FF13B for ; Mon, 08 Jun 2026 09:42:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 993B314A6F; Mon, 8 Jun 2026 09:42:08 +0200 (CEST) Date: Mon, 8 Jun 2026 09:42:03 +0200 From: Stoiko Ivanov To: Dominik Csapak Subject: Re: [PATCH pmg-api/pmg-docs/pmg-gui 0/5] add optional consent-banner to be shown before login Message-ID: <20260608094203.4186cfb9@rosa.proxmox.com> In-Reply-To: <080831a6-4b04-4030-b174-0fac7710f877@proxmox.com> References: <20260608065653.624545-1-s.ivanov@proxmox.com> <080831a6-4b04-4030-b174-0fac7710f877@proxmox.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780904480613 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.086 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm,pmgproxy.pm,proxmox.com,html.tt] Message-ID-Hash: 65QSLVZGLAOVIPYK4QNYZWG2OLMOQ36V X-Message-ID-Hash: 65QSLVZGLAOVIPYK4QNYZWG2OLMOQ36V X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pmg-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for checking the patches! On Mon, 8 Jun 2026 09:19:32 +0200 Dominik Csapak wrote: > had a look over the code and tested a bit. > > a few high level points: > > * not sure if we would benefit from refactoring the 'consent-text' > schema/format into pve-common (this was recently also done for the > 'location', but since we only have it in two places currently > i'd tend not to, so this looks currently fine to me As it's 2 places I'd also tend to keep it in pve-cluster/pmg-api for now. > > * the consent text will not be shown in the quarantine view. > my guess is that users who need the consent text also need it in the > quarantine (maybe even before automatically logging in?) > should we add a separate consent text? we could always add this later > too though. If we add this, we'd also have to add it in the mobile > quarantine of course. Hm - did not consider that - and if there's demand for it and we implement it I'd definitely say it needs to be 2 separate texts, or to have the option to enable it for the admin-interface only. The UX of clicking on an action in your report mail and then having to click on the consent banner before it gets done seems like it might make sense to not send the action links in those cases (but users who enable the consent-banner for the quarantine interface can adapt their report-templates). For me this can be done at a later point. > > > Aside from these, consider the patches: > > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak > > > On 6/8/26 8:57 AM, Stoiko Ivanov wrote: > > The idea is taken, and the code mostly copied from PVE, where this was > > added to address: > > https://bugzilla.proxmox.com/show_bug.cgi?id=5463 > > > > pmg-docs: > > > > Stoiko Ivanov (1): > > pmgconfig: add short documentation of the consent banner > > > > pmgconfig.adoc | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > > > pmg-api: > > > > Stoiko Ivanov (2): > > config: add consent-text key > > pmgproxy: pass consent-text as template variable to index > > > > src/PMG/Config.pm | 7 +++++++ > > src/PMG/Service/pmgproxy.pm | 2 ++ > > 2 files changed, 9 insertions(+) > > > > > > pmg-gui: > > > > Stoiko Ivanov (2): > > login: show optional consent-banner before login > > system options: add online help link for consent banner > > > > js/LoginView.js | 11 +++++++++++ > > js/SystemOptions.js | 8 ++++++++ > > pmg-index.html.tt | 1 + > > 3 files changed, 20 insertions(+) > > > > > > Summary over all repositories: > > 6 files changed, 36 insertions(+), 0 deletions(-) > > >