From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8F9081FF141 for ; Mon, 16 Mar 2026 13:17:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9896818441; Mon, 16 Mar 2026 13:17:56 +0100 (CET) Date: Mon, 16 Mar 2026 13:17:52 +0100 From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Subject: Re: [PATCH pmg-api v2] fix #7407: cluster: report: increase maximal filesize to 2M Message-ID: <20260316131752.5daa15d2@rosa.proxmox.com> In-Reply-To: <20260316121307.30168-1-s.ivanov@proxmox.com> References: <20260316121307.30168-1-s.ivanov@proxmox.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773663432420 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AHK3GSGQA67XRAC6Y4SYBQ56SMO3JBAO X-Message-ID-Hash: AHK3GSGQA67XRAC6Y4SYBQ56SMO3JBAO X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: superseded by: https://lore.proxmox.com/pmg-devel/20260316121712.30273-1-s.ivanov@proxmox.com/T/#u where the commit-message was also adapted sorry for the noise On Mon, 16 Mar 2026 13:12:43 +0100 Stoiko Ivanov wrote: > the postfix configuration files are read via PVE::INotify in our > stack and have not implicit limit. > > PMG::Cluster and PMG::Report do read the same file's contents using > `file_get_contents` with a limit (explicitly set, or implicit) of 1M. > > This causes the cluster-sync to fail in one reported deployment > hosting ~40k domains, with explicit transport entries and comments > (resulting in a 1.4M /etc/pmg/transport). > > As it's the first occurrence of this causing an issue doubling the > limit to 2M, instead of increasing it further seems appropriate. > > Signed-off-by: Stoiko Ivanov > --- > v1->v2: > * increase size to 4M based on feedback from Dominik - thx! > > src/PMG/Cluster.pm | 4 ++-- > src/PMG/Report.pm | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/PMG/Cluster.pm b/src/PMG/Cluster.pm > index 02d727ee..3e0b12ac 100644 > --- a/src/PMG/Cluster.pm > +++ b/src/PMG/Cluster.pm > @@ -266,10 +266,10 @@ my $cond_commit_synced_file = sub { > return; > } > > - my $new = PVE::Tools::file_get_contents($srcfn, 1024 * 1024); > + my $new = PVE::Tools::file_get_contents($srcfn, 4096 * 1024); > > if (-f $dstfn) { > - my $old = PVE::Tools::file_get_contents($dstfn, 1024 * 1024); > + my $old = PVE::Tools::file_get_contents($dstfn, 4096 * 1024); > return 0 if $new eq $old; > } > > diff --git a/src/PMG/Report.pm b/src/PMG/Report.pm > index 84d1b887..58756c77 100644 > --- a/src/PMG/Report.pm > +++ b/src/PMG/Report.pm > @@ -72,7 +72,7 @@ sub dir2text { > sub { > my ($file) = @_; > $report .= "\n# cat $target_dir$file\n"; > - $report .= PVE::Tools::file_get_contents($target_dir . $file) . "\n"; > + $report .= PVE::Tools::file_get_contents($target_dir . $file, 4096 * 1024) . "\n"; > }, > ); > }