From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AF7681FF17A for ; Tue, 28 Oct 2025 17:36:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4B4791FFDD; Tue, 28 Oct 2025 17:36:39 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Tue, 28 Oct 2025 17:36:16 +0100 Message-ID: <20251028163628.79739-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251028163628.79739-1-s.ivanov@proxmox.com> References: <20251028163628.79739-1-s.ivanov@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761669383136 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [RFC pmg-yew-quarantine-gui 1/2] buildsys: initialize pwt-assets as submodule automatically X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" The error-message for the missing submodule and prerequisite is clear, but due to parallel make - it gets printed, before the rustc output - and is thus not visible when the build fails. inspired by our zfsonlinux git: 63bd3935c (ensure submodule gets initialized on fresh clone and build). but instead of letting BUILDDIR depend on pwt-assets/README.md it depends on the PHONY target (as this will evaluated anyways - and short-circuit if the README.md exists) Signed-off-by: Stoiko Ivanov --- Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index fdf046c..72937c0 100644 --- a/Makefile +++ b/Makefile @@ -66,8 +66,11 @@ install: $(COMPILED_OUTPUT) pmg-mobile-index.html.tt install -m0644 dist/mobile-yew-style.css $(DESTDIR)$(UIDIR)/css install -m0644 pmg-mobile-index.html.tt $(DESTDIR)$(UIDIR) +.PHONY: submodule +submodule: + test -f "pwt-assets/README.md" || git submodule update --init -$(BUILDDIR): +$(BUILDDIR): submodule rm -rf $@ $@.tmp mkdir -p $@.tmp cp -a debian/ src/ pwt-assets/ images/ pmg-mobile-index.html.tt Makefile Cargo.toml $@.tmp -- 2.47.3 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel