From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8AE5D1FF187 for ; Mon, 22 Sep 2025 11:47:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DD8EF16C30; Mon, 22 Sep 2025 11:47:32 +0200 (CEST) Date: Mon, 22 Sep 2025 11:46:59 +0200 From: Stoiko Ivanov To: Fiona Ebner Message-ID: <20250922114659.3aa7e5f2@rosa.proxmox.com> In-Reply-To: <20250918142052.131956-3-f.ebner@proxmox.com> References: <20250918142052.131956-1-f.ebner@proxmox.com> <20250918142052.131956-3-f.ebner@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758534408045 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api 2/4] partially fix #2077: pmgcm: remove dependency on Term::ReadLine X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmg-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" Tested this by creating a cluster on a trixie based container, and joining it to my bookworm PMG (the trixie container had pve-common containing: https://lore.proxmox.com/pve-devel/20250918135215.95188-2-f.ebner@proxmox.com/ and this patch applied) Consider this: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Thu, 18 Sep 2025 16:19:42 +0200 Fiona Ebner wrote: > Signed-off-by: Fiona Ebner > --- > src/PMG/CLI/pmgcm.pm | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/src/PMG/CLI/pmgcm.pm b/src/PMG/CLI/pmgcm.pm > index ab9fe2a..401f680 100644 > --- a/src/PMG/CLI/pmgcm.pm > +++ b/src/PMG/CLI/pmgcm.pm > @@ -3,7 +3,6 @@ package PMG::CLI::pmgcm; > use strict; > use warnings; > use Data::Dumper; > -use Term::ReadLine; > use POSIX qw(strftime); > use JSON; > > @@ -11,6 +10,7 @@ use PVE::SafeSyslog; > use PVE::Tools qw(extract_param); > use PVE::INotify; > use PVE::CLIHandler; > +use PVE::PTY; > > use PMG::Utils; > use PMG::Ticket; > @@ -188,10 +188,7 @@ __PACKAGE__->register_method({ > > die "cluster already defined\n" if scalar(keys %{ $cinfo->{ids} }); > > - my $term = new Term::ReadLine('pmgcm'); > - my $attribs = $term->Attribs; > - $attribs->{redisplay_function} = $attribs->{shadow_redisplay}; > - my $password = $term->readline('Enter password: '); > + my $password = PVE::PTY::read_password('Enter password: '); > > my $setup = { > username => 'root@pam', _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel