From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0C4EC1FF165 for ; Thu, 14 Aug 2025 02:08:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E5E2E3DF24; Thu, 14 Aug 2025 02:10:14 +0200 (CEST) Date: Thu, 14 Aug 2025 02:10:11 +0200 From: Stoiko Ivanov To: Maximiliano Sandoval Message-ID: <20250814021011.06732e9d@rosa.proxmox.com> In-Reply-To: <20250404131438.328396-2-m.sandoval@proxmox.com> References: <20250404131438.328396-1-m.sandoval@proxmox.com> <20250404131438.328396-2-m.sandoval@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755130179396 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api v5 02/11] pmg-smtp-filter: move pid file into /run/pmg-smtp-filter X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmg-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" the pmg-smtp-filter is started by a few of our internal tests - which seems to break due to this change (looks like systemd removes the RuntimeDirectory when the service stops...) If in doubt - just create it when starting? On Fri, 4 Apr 2025 15:14:29 +0200 Maximiliano Sandoval wrote: > We use systemd's RuntimeDirectory to ensure the directory exists when needed. > > We also set $opt_pidfile using PIDFILE, see > https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#%24PIDFILE. > > Signed-off-by: Maximiliano Sandoval > --- > debian/pmg-smtp-filter.service | 3 ++- > src/PMG/Utils.pm | 2 +- > src/bin/pmg-smtp-filter | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/debian/pmg-smtp-filter.service b/debian/pmg-smtp-filter.service > index cbf2d6f3..c887dc2d 100644 > --- a/debian/pmg-smtp-filter.service > +++ b/debian/pmg-smtp-filter.service > @@ -11,10 +11,11 @@ ExecStart=/usr/bin/pmg-smtp-filter > KillMode=mixed > TimeoutStopSec=40 > ExecReload=/bin/kill -HUP $MAINPID > -PIDFile=/run/pmg-smtp-filter.pid > +PIDFile=/run/pmg-smtp-filter/pmg-smtp-filter.pid > Type=forking > Restart=on-abort > RestartSec=10 > +RuntimeDirectory=pmg-smtp-filter > > [Install] > WantedBy=multi-user.target > diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm > index 3e7adbb6..07a6c9be 100644 > --- a/src/PMG/Utils.pm > +++ b/src/PMG/Utils.pm > @@ -1515,7 +1515,7 @@ sub get_pg_server_version { > > sub reload_smtp_filter { > > - my $pid_file = '/run/pmg-smtp-filter.pid'; > + my $pid_file = '/run/pmg-smtp-filter/pmg-smtp-filter.pid'; > my $pid = PVE::Tools::file_read_firstline($pid_file); > > return 0 if !$pid; > diff --git a/src/bin/pmg-smtp-filter b/src/bin/pmg-smtp-filter > index 32bad7b8..fcaaffc5 100755 > --- a/src/bin/pmg-smtp-filter > +++ b/src/bin/pmg-smtp-filter > @@ -80,7 +80,7 @@ if (!GetOptions( > exit (-1); > } > > -$opt_pidfile = "/run/${prog_name}.pid" if !$opt_pidfile; > +$opt_pidfile = $ENV{'PIDFILE'} if !$opt_pidfile; > > my $max_servers = 1; > my $min_servers = 1; _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel