From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pmg-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 659661FF16F
for <inbox@lore.proxmox.com>; Thu, 27 Feb 2025 08:56:01 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 2D1322B7E1;
Thu, 27 Feb 2025 08:56:00 +0100 (CET)
From: Markus Frank <m.frank@proxmox.com>
To: pmg-devel@lists.proxmox.com
Date: Thu, 27 Feb 2025 08:55:16 +0100
Message-Id: <20250227075517.3364-2-m.frank@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250227075517.3364-1-m.frank@proxmox.com>
References: <20250227075517.3364-1-m.frank@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.013 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pmg-devel] [PATCH widget-toolkit v1 1/2] window: add optional
autocreate-role selector to openid realm edit
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
<pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pmg-devel-bounces@lists.proxmox.com
Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com>
The enableRoleSelector option enables the role selector, and
roleSelector can be overridden with a specific role selector such as
pmgRoleSelector (displayfield is used as a placeholder for the role
selector).
Signed-off-by: Markus Frank <m.frank@proxmox.com>
---
src/panel/AuthView.js | 4 ++++
src/window/AuthEditBase.js | 6 ++++++
src/window/AuthEditOpenId.js | 35 +++++++++++++++++++++++------------
3 files changed, 33 insertions(+), 12 deletions(-)
diff --git a/src/panel/AuthView.js b/src/panel/AuthView.js
index 7bebf0d..2f777fc 100644
--- a/src/panel/AuthView.js
+++ b/src/panel/AuthView.js
@@ -14,6 +14,8 @@ Ext.define('Proxmox.panel.AuthView', {
baseUrl: '/access/domains',
storeBaseUrl: '/access/domains',
+ enableRoleSelector: false,
+ roleSelector: 'displayfield',
columns: [
{
@@ -54,6 +56,8 @@ Ext.define('Proxmox.panel.AuthView', {
Ext.create('Proxmox.window.AuthEditBase', {
baseUrl: me.baseUrl,
+ enableRoleSelector: me.enableRoleSelector,
+ roleSelector: me.roleSelector,
useTypeInUrl,
onlineHelp,
authType,
diff --git a/src/window/AuthEditBase.js b/src/window/AuthEditBase.js
index e044235..861d082 100644
--- a/src/window/AuthEditBase.js
+++ b/src/window/AuthEditBase.js
@@ -12,6 +12,8 @@ Ext.define('Proxmox.window.AuthEditBase', {
baseurl: '/access/domains',
useTypeInUrl: false,
+ enableRoleSelector: false,
+ roleSelector: 'displayfield',
initComponent: function() {
var me = this;
@@ -53,6 +55,8 @@ Ext.define('Proxmox.window.AuthEditBase', {
title: gettext('General'),
realm: me.realm,
xtype: authConfig.ipanel,
+ enableRoleSelector: me.enableRoleSelector,
+ roleSelector: me.roleSelector,
isCreate: me.isCreate,
useTypeInUrl: me.useTypeInUrl,
type: me.authType,
@@ -71,6 +75,8 @@ Ext.define('Proxmox.window.AuthEditBase', {
items = [{
realm: me.realm,
xtype: authConfig.ipanel,
+ enableRoleSelector: me.enableRoleSelector,
+ roleSelector: me.roleSelector,
isCreate: me.isCreate,
useTypeInUrl: me.useTypeInUrl,
type: me.authType,
diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js
index ed0a6dc..3610c71 100644
--- a/src/window/AuthEditOpenId.js
+++ b/src/window/AuthEditOpenId.js
@@ -66,18 +66,6 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', {
},
name: 'client-key',
},
- ],
-
- column2: [
- {
- xtype: 'proxmoxcheckbox',
- fieldLabel: gettext('Autocreate Users'),
- name: 'autocreate',
- value: 0,
- cbind: {
- deleteEmpty: '{!isCreate}',
- },
- },
{
xtype: 'pmxDisplayEditField',
name: 'username-claim',
@@ -98,6 +86,29 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', {
editable: '{isCreate}',
},
},
+ ],
+
+ column2: [
+ {
+ xtype: 'proxmoxcheckbox',
+ fieldLabel: gettext('Autocreate Users'),
+ name: 'autocreate',
+ value: 0,
+ cbind: {
+ deleteEmpty: '{!isCreate}',
+ },
+ },
+ {
+ name: 'autocreate-role',
+ allowBlank: true,
+ deleteEmpty: false,
+ fieldLabel: gettext('Autocreate Role'),
+ cbind: {
+ xtype: '{roleSelector}',
+ disabled: '{!enableRoleSelector}',
+ hidden: '{!enableRoleSelector}',
+ },
+ },
{
xtype: 'proxmoxtextfield',
name: 'scopes',
--
2.39.5
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel