From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmg-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id CF6641FF165
	for <inbox@lore.proxmox.com>; Wed, 26 Feb 2025 15:47:24 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 1E08E17368;
	Wed, 26 Feb 2025 15:47:24 +0100 (CET)
Date: Wed, 26 Feb 2025 15:46:50 +0100
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Message-ID: <20250226154650.531a692a@rosa.proxmox.com>
In-Reply-To: <72c041a2-7b71-4985-9c10-e504963ee09e@proxmox.com>
References: <20250226141813.542154-1-s.ivanov@proxmox.com>
 <72c041a2-7b71-4985-9c10-e504963ee09e@proxmox.com>
X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu)
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.066 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pmg-devel] [PATCH pmg-docs] pmgconfig: document DKIM signing
 local mail
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
 <pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
Cc: pmg-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pmg-devel-bounces@lists.proxmox.com
Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com>

Thanks for the fast feedback - good suggestions!

one question inline:

On Wed, 26 Feb 2025 15:39:25 +0100
Fiona Ebner <f.ebner@proxmox.com> wrote:

> Am 26.02.25 um 15:18 schrieb Stoiko Ivanov:
> > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> > ---
> >  pmgconfig.adoc | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/pmgconfig.adoc b/pmgconfig.adoc
> > index 3ac8973..c093051 100644
> > --- a/pmgconfig.adoc
> > +++ b/pmgconfig.adoc
> > @@ -575,6 +575,13 @@ You can either sign all mails received on the internal port using the domain of
> >  the envelope sender address or create a list of domains, for which emails
> >  should be signed, defaulting to the list of relay domains.
> >  
> > +Mails generated by {pmg} itself, like notifications and reports, usually have
> > +an empty envelope. Thus they will only be signed if you have selected `header`
> > +as source of the signing domain and have set a RFC5322.From with a domain that  
> 
> "as source" -> "as the source"
> 
> s/a RFC/an RFC/ (because it's read as "ar-ef-zee")
> 
> "with a domain" -> "to a domain"?
the from header has a display name ("Stoiko Ivanov") and an address
(<s.ivanov@proxmox.com>) - so setting this 'to a domain that ...' seems
unfitting, and writing:
have set a RFC5322.From with an address that is in a domain...
seems a bit unwieldy?

would be grateful for alternatives

> 
> > +would be signed as `From:` setting in the  
> 
> "as `From:` setting" -> "as a `From:` setting"?
> 
> > +xref:pmgconfig_spamdetector_quarantine[spam quarantine options] for spamreports  
> 
> "spamreports" -> "spam reports"?
> 
> > +and quarantine links, and in the xref:pmgconfig_systemconfig[system options] for
> > +other mails send by {pmg}.  
> 
> s/send/sent/
> 
> >  
> >  Enable DKIM Signing::
> >    
> 



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel