From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pmg-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6F87C1FF15E for <inbox@lore.proxmox.com>; Tue, 25 Feb 2025 16:02:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A617C1FDD4; Tue, 25 Feb 2025 16:02:15 +0100 (CET) From: Stoiko Ivanov <s.ivanov@proxmox.com> To: pmg-devel@lists.proxmox.com Date: Tue, 25 Feb 2025 16:01:56 +0100 Message-Id: <20250225150203.455669-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [quarantine.pm, notify.pm, backup.pm, utils.pm, proxmox.com, pmgreport.pm, dkimsign.pm, config.pm, smtp.pm] Subject: [pmg-devel] [PATCH pmg-api/pmg-gui v2 0/6] DKIM sign mails generated by PMG itself. X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com> supersedes: https://lore.proxmox.com/pmg-devel/20250225102656.413135-1-s.ivanov@proxmox.com/T/#u https://lore.proxmox.com/pmg-devel/20250224232451.399803-1-s.ivanov@proxmox.com/T/#t v1->v2: * add pattern, and lenght restriction on from-header format (patch 1) * use the default setting of 'Proxmox Mail Gateway <postmaster>' everywhere instead of special-casing * change the dkim-signing to not die when receiving an empty or domain-less envelope-sender (I only tested the positive case yesterday, where signing source was the header) - keep in mind that the effect was a warning in the journal, which is now a info * add the minimal GUI-patch to the series I kept patch 1/1 seperately, mostly due to the change being used in all 3 following patches (and since the commit-message as to why the change should not cause regression grew rather large) I'm fine with all 3 patches being squashed together if this seems better to anyone. Thanks very much to Maximilano and Dominik for the feedback provided pmg-api: Stoiko Ivanov (6): config: add admin-mail-from key reports: use admin-mail-from as from header smtp-engine: use admin-mail-from as from header for bounces ruledb: use admin-mail-from where sensible dkim: signer: log info instead of die'ing when missing domain reinject_local_mail: sign mails with DKIM based on header src/PMG/Backup.pm | 2 +- src/PMG/CLI/pmgreport.pm | 2 +- src/PMG/Config.pm | 7 +++++++ src/PMG/DKIMSign.pm | 10 ++++++++-- src/PMG/Quarantine.pm | 1 + src/PMG/RuleDB/Notify.pm | 8 ++++---- src/PMG/SMTP.pm | 7 ++++--- src/PMG/Utils.pm | 15 +++++++++++++++ src/bin/pmg-smtp-filter | 1 + 9 files changed, 42 insertions(+), 11 deletions(-) pmg-gui: Stoiko Ivanov (1): configuration: options: add admin-mail-from row. js/SystemOptions.js | 3 +++ 1 file changed, 3 insertions(+) -- 2.39.5 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel