From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pmg-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id E0FA61FF15E
for <inbox@lore.proxmox.com>; Tue, 25 Feb 2025 11:29:32 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id B23C71A2AE;
Tue, 25 Feb 2025 11:29:32 +0100 (CET)
Date: Tue, 25 Feb 2025 11:29:29 +0100
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Message-ID: <20250225112929.473091ff@rosa.proxmox.com>
In-Reply-To: <s8oseo2e4e6.fsf@proxmox.com>
References: <20250224232451.399803-1-s.ivanov@proxmox.com>
<20250224232451.399803-4-s.ivanov@proxmox.com>
<s8oseo2e4e6.fsf@proxmox.com>
X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu)
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.067 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pmg-devel] [PATCH pmg-api 3/7] smtp-engine: use
admin-mail-from as from header for bounces
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
<pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
Cc: pmg-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pmg-devel-bounces@lists.proxmox.com
Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com>
On Tue, 25 Feb 2025 10:53:29 +0100
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:
> Stoiko Ivanov <s.ivanov@proxmox.com> writes:
>
> > generate_ndr is currently only used to generate a bounce-mail if the
> > following occur:
> > * email is blocked only for part of the receivers
> > * before-queue-filtering is active - in the after-queue case postfix
> > generates the bounces for us.
> >
> > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> > ---
> > src/PMG/SMTP.pm | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/PMG/SMTP.pm b/src/PMG/SMTP.pm
> > index b7bc5d3..f387fcb 100644
> > --- a/src/PMG/SMTP.pm
> > +++ b/src/PMG/SMTP.pm
> > @@ -185,7 +185,8 @@ sub loop {
> > $self->reply ("250 2.5.0 OK ($queueid)");
> > if ($cfg->get('mail', 'ndr_on_block')) {
> > my $dnsinfo = $cfg->get_host_dns_info();
> > - generate_ndr($self->{from}, [ @reject_rec ], $dnsinfo->{fqdn}, $queueid) if scalar(@reject_rec);
> > + my $from_header = $cfg->get('admin', 'admin-mail-from', 1) // '<postmaster>';
> > + generate_ndr($self->{from}, [ @reject_rec ], $dnsinfo->{fqdn}, $queueid, $from_header) if scalar(@reject_rec);
> > }
> > } else {
> > $self->reply ("451 4.4.0 detected undelivered mail ($queueid)");
> > @@ -265,7 +266,7 @@ sub save_data {
> > }
> >
> > sub generate_ndr {
> > - my ($sender, $receivers, $hostname, $queueid) = @_;
> > + my ($sender, $receivers, $hostname, $queueid, $from_header) = @_;
>
> This function would imo benefit from either having a NULL check for
> `$from_header` or by defining here the fallback value.
Thanks - good catch - as generate_ndr currently only used once (in the
lines above) - I think `die .. if !defined($from_header)` should not hurt
will add this in a v2 (but would wait for some more feedback)
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel