From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmg-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id DB81D1FF173
	for <inbox@lore.proxmox.com>; Mon, 24 Feb 2025 13:20:31 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 2702FD73;
	Mon, 24 Feb 2025 13:20:29 +0100 (CET)
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Date: Mon, 24 Feb 2025 13:19:35 +0100
Message-Id: <20250224121935.306240-1-s.ivanov@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.067 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pmg-devel] [RFC pmg-gui] fix #4311: add quarantine help-page for
 end-users
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
 <pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pmg-devel-bounces@lists.proxmox.com
Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com>

Having a short explanation of what the quarantine interface provides,
in the end-user interface should help users who wonder why they get
mails from some system, and what quarantine means. Instead of adding
this to the regular documentation and linking it in the top-bar as we
do in the admin-view having a short description directly rendered on
the main panel should increase the chances of it getting read.

the code is inspired by the notesview (I found it when clicking
through a PBS system of mine looking for how to address this).

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
Sending as RFC as I'm not quite sure if having this as static entry in
the GUI is a good fit. If we want to keep it this way, I'd replace the
`Proxmox.Markdown.parse` call with the rendered html.

One alternative that came to my mind while writing this is having the
markdown text in the backend as a template. This would give admins an
easy way to customize this to their needs, and provide it in their
local language.

Additionally of course feedback on the (rather terse) phrasing itself
is of course also appreciated.


 js/Makefile               |  1 +
 js/QuarantineView.js      |  8 +++++++
 js/QuarantineViewAbout.js | 44 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 53 insertions(+)
 create mode 100644 js/QuarantineViewAbout.js

diff --git a/js/Makefile b/js/Makefile
index 2fb7d19..d1fab9b 100644
--- a/js/Makefile
+++ b/js/Makefile
@@ -31,6 +31,7 @@ JSSRC=							\
 	SpamQuarantine.js				\
 	UserBlackWhiteList.js				\
 	QuarantineView.js				\
+	QuarantineViewAbout.js				\
 	Dashboard.js					\
 	dashboard/MailProcessing.js			\
 	dashboard/NodeInfo.js				\
diff --git a/js/QuarantineView.js b/js/QuarantineView.js
index 5b70487..17f1847 100644
--- a/js/QuarantineView.js
+++ b/js/QuarantineView.js
@@ -1,4 +1,5 @@
 Ext.define('PMG.QuarantineNavigationTree', {
+
     extend: 'Ext.list.Tree',
     xtype: 'quarantinenavigationtree',
 
@@ -32,6 +33,13 @@ Ext.define('PMG.QuarantineNavigationTree', {
 			},
 		    ],
 		},
+		{
+		    text: gettext('Help'),
+		    iconCls: 'fa fa-support',
+		    path: 'pmgQuarantineAbout',
+		    leaf: true,
+		    expanded: true,
+		},
 	    ],
 	},
     },
diff --git a/js/QuarantineViewAbout.js b/js/QuarantineViewAbout.js
new file mode 100644
index 0000000..252a757
--- /dev/null
+++ b/js/QuarantineViewAbout.js
@@ -0,0 +1,44 @@
+// Needs to be its own xtype for `path` to work in `NavigationTree`
+Ext.define('PMG.QuarantineAboutPage', {
+    extend: 'Ext.panel.Panel',
+    xtype: 'pmgQuarantineAbout',
+
+    bodyPadding: 10,
+    title: 'Proxmox Mail Gateway Quarantine Help',
+
+    html: Proxmox.Markdown.parse(
+`# About
+This is the email quarantine interface for end-users provided by your email provider.
+
+Proxmox Mail Gateway is Software used to scan emails for threats like spam or viruses.
+
+Usually emails that contain viruses or are detected as being certain spam are blocked by your
+provider.
+Emails that are not classified as certain spam may be put into quarantine, where the recipient can
+decide if they want to receive or delete them. In most setups you will receive a Spam Report email
+to notify you, if your address has mail put in its quarantine.
+
+Additionally you have the option to block or welcome certain addresses in general.
+* Welcoming, in the Whitelist menu, results in the mails being directly delivered,
+instead of being stored in quarantine.
+* Blocking, in the Blacklist menu, results in the mails being directly deleted,
+instead of being stored in quarantine.
+
+
+**Note:** The sending of Spam Report emails and this Webpage are controlled by your email provider.
+
+Proxmox Server Solutions GmbH develops the software and is not running mail services for users.
+
+## Shortcuts
+
+When you have selected an entry in your quarantine you can use the following keyboard short-cuts
+in place of the buttons on top:
+
+* **D:** Deliver the mail
+* **Delete:** Delete the mail
+* **B:** Add the sender to the Blocklist/Blacklist
+* **W:** Add the sender to the Welcomelist/Whitelist
+`),
+
+});
+
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel