From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7B2C31FF15C for ; Wed, 30 Oct 2024 12:19:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F2D3116573; Wed, 30 Oct 2024 12:19:30 +0100 (CET) From: Maximiliano Sandoval To: pmg-devel@lists.proxmox.com Date: Wed, 30 Oct 2024 12:18:57 +0100 Message-Id: <20241030111857.166676-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-api] api: make SHA-256 fingerprint regex match only hex characters X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" The fingerprints are in hex, plus colons, and should only match A-F. Suggested-by: Shannon Sterz Signed-off-by: Maximiliano Sandoval --- src/PMG/API2/Cluster.pm | 2 +- src/PMG/CLI/pmgcm.pm | 2 +- src/PMG/ClusterConfig.pm | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PMG/API2/Cluster.pm b/src/PMG/API2/Cluster.pm index 84dafabb..cc54fb50 100644 --- a/src/PMG/API2/Cluster.pm +++ b/src/PMG/API2/Cluster.pm @@ -411,7 +411,7 @@ __PACKAGE__->register_method({ fingerprint => { description => "SSL certificate fingerprint.", type => 'string', - pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$', + pattern => '^(:?[A-F0-9][A-F0-9]:){31}[A-F0-9][A-F0-9]$', }, password => { description => "Superuser password.", diff --git a/src/PMG/CLI/pmgcm.pm b/src/PMG/CLI/pmgcm.pm index ecf9cc76..641b4be2 100644 --- a/src/PMG/CLI/pmgcm.pm +++ b/src/PMG/CLI/pmgcm.pm @@ -169,7 +169,7 @@ __PACKAGE__->register_method({ fingerprint => { description => "SSL certificate fingerprint.", type => 'string', - pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$', + pattern => '^(:?[A-F0-9][A-F0-9]:){31}[A-F0-9][A-F0-9]$', optional => 1, }, }, diff --git a/src/PMG/ClusterConfig.pm b/src/PMG/ClusterConfig.pm index c52508dc..67b2a512 100644 --- a/src/PMG/ClusterConfig.pm +++ b/src/PMG/ClusterConfig.pm @@ -75,7 +75,7 @@ sub properties { fingerprint => { description => "SSL certificate fingerprint.", type => 'string', - pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$', + pattern => '^(:?[A-F0-9][A-F0-9]:){31}[A-F0-9][A-F0-9]$', }, }; } -- 2.39.5 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel