From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pmg-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 35F8B1FF15E for <inbox@lore.proxmox.com>; Fri, 4 Oct 2024 15:47:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 622A4FC2E; Fri, 4 Oct 2024 15:47:24 +0200 (CEST) From: Stoiko Ivanov <s.ivanov@proxmox.com> To: pmg-devel@lists.proxmox.com Date: Fri, 4 Oct 2024 15:47:00 +0200 Message-Id: <20241004134702.14522-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-api v2 0/2] sa-custom: move shadow config next to live config X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com> supersedes: https://lore.proxmox.com/pmg-devel/7d32a0e7-083e-4c2d-bcca-0dd55e0ec5cc@proxmox.com/T/#t changes v1->v2: * following Thomas' and Dominik's feedback simply moved the shadow file to the same directory as the live one (after checking what SA does when parsing its config) - Thanks for the suggestion! * patch 2/2 moves the file upon package installation. original cover-letter for v1: the custom scores are kept in /var/cache/pmg-scores.cf, until they are applied, by moving them to /etc/mail/spamassassin/pmg-scores.cf. This currently happens with perl's `rename` function [0], which is a wrapper for rename(2). `rename` does not work across filesystem boundaries (errors out with EXDEV). having `/var` on another filesystem is becoming less common, but should probably be supported. following the recommendation of [0] switch over to `File::Copy::move`, and add some error-checking. File::Copy is shipped with perl-modules-5.36, thus it does not introduce a new dependency reported in our community-forum: https://forum.proxmox.com/threads/.154814/ tested in a container with a seperate volume for `/var/cache`. other occurences of `rename` in the repo should not be affected (moving files within the same directory, or e.g. from /etc/pmg/master to /etc/pmg). [0] https://perldoc.perl.org/functions/rename Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> Stoiko Ivanov (2): sa-custom: move shadow config to the same directory d/postinst: move pmg-scores.cf shadow file to new location debian/postinst | 11 +++++++++++ src/PMG/SACustom.pm | 6 ++++-- 2 files changed, 15 insertions(+), 2 deletions(-) -- 2.39.5 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel