From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8EA381FF37F for ; Tue, 18 Jun 2024 17:30:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 041A31E526; Tue, 18 Jun 2024 17:31:00 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Tue, 18 Jun 2024 17:30:15 +0200 Message-Id: <20240618153015.51851-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, utils.pm] Subject: [pmg-devel] [PATCH pmg-api] utils: custom check: fix error in spamscore regex X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" Currently a reply with a negative spam-score with fractional part like: v1 SCORE: -1.52 yields an error (as the optional '-' is only accepted as part of the first alternative. quickly tested with a very minimal custom-checkscript (that returns the output above). reported in our community forum: https://forum.proxmox.com/threads/.148927/#post-675209 Signed-off-by: Stoiko Ivanov --- src/PMG/Utils.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm index 5d9ded4..b91d697 100644 --- a/src/PMG/Utils.pm +++ b/src/PMG/Utils.pm @@ -383,7 +383,7 @@ sub analyze_custom_check { $customcheck_output_apiver = $line; die "api version mismatch - expected $customcheck_apiver, got $customcheck_output_apiver !\n" if ($customcheck_output_apiver ne $customcheck_apiver); - } elsif ($line =~ /^SCORE: (-?[0-9]+|.[0-9]+|[0-9]+.[0-9]+)$/) { + } elsif ($line =~ /^SCORE: (-?(?:[0-9]+|.[0-9]+|[0-9]+.[0-9]+))$/) { $spam_score = $1; $result_flag = 1; } elsif ($line =~ /^VIRUS: (.+)$/) { -- 2.39.2 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel