From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <s.ivanov@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 4F02596C50
for <pmg-devel@lists.proxmox.com>; Fri, 1 Mar 2024 11:41:50 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 30BAA304D8
for <pmg-devel@lists.proxmox.com>; Fri, 1 Mar 2024 11:41:50 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pmg-devel@lists.proxmox.com>; Fri, 1 Mar 2024 11:41:49 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 489CA4834C
for <pmg-devel@lists.proxmox.com>; Fri, 1 Mar 2024 11:41:49 +0100 (CET)
Date: Fri, 1 Mar 2024 11:41:48 +0100
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Stefan Sterz <s.sterz@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Message-ID: <20240301114148.26264573@rosa.proxmox.com>
In-Reply-To: <20240301095430.64525-1-s.sterz@proxmox.com>
References: <20240301095430.64525-1-s.sterz@proxmox.com>
X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.081 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: [pmg-devel] applied: [PATCH pmg-gui] ui: trim whitespaces when
adding a subscription key
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
<pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 01 Mar 2024 10:41:50 -0000
Thanks for the patch! applied after testing it in a fresh pmg-8.1 container
On Fri, 1 Mar 2024 10:54:30 +0100
Stefan Sterz <s.sterz@proxmox.com> wrote:
> users that add the correct subscription key just get unnecessarily
> confused with a "value does not match the regex pattern" error if
> they accidentally have a stray whitespace at the end or beginning
> otherwise.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> js/Subscription.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/js/Subscription.js b/js/Subscription.js
> index 2293cdb..6d7380c 100644
> --- a/js/Subscription.js
> +++ b/js/Subscription.js
> @@ -8,7 +8,8 @@ Ext.define('PMG.SubscriptionKeyEdit', {
> onlineHelp: 'getting_help',
>
> items: {
> - xtype: 'textfield',
> + xtype: 'proxmoxtextfield',
> + trimValue: true,
> name: 'key',
> value: '',
> fieldLabel: gettext('Subscription Key'),