From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0E69B9550B for ; Mon, 26 Feb 2024 17:35:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EB3BC12E49 for ; Mon, 26 Feb 2024 17:35:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 26 Feb 2024 17:35:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A2262472EB for ; Mon, 26 Feb 2024 17:35:54 +0100 (CET) Date: Mon, 26 Feb 2024 17:35:53 +0100 From: Stoiko Ivanov To: Maximiliano Sandoval Cc: pmg-devel@lists.proxmox.com Message-ID: <20240226173553.34e34dca@rosa.proxmox.com> In-Reply-To: <20240223125200.429723-1-m.sandoval@proxmox.com> References: <20240223125200.429723-1-m.sandoval@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pmg-devel] applied: [PATCH pmg-gui] fix #2971: DKIM: add gui setting to use From header when signing X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2024 16:35:56 -0000 applied the patch after testing it shortly in my setup - Thanks! On Fri, 23 Feb 2024 13:52:00 +0100 Maximiliano Sandoval wrote: > Signed-off-by: Maximiliano Sandoval > --- > js/DKIMSettings.js | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/js/DKIMSettings.js b/js/DKIMSettings.js > index 9cebfeb..21f572d 100644 > --- a/js/DKIMSettings.js > +++ b/js/DKIMSettings.js > @@ -120,6 +120,11 @@ Ext.define('PMG.DKIMSettings', { > > monStoreErrors: true, > > + dkimdomainTextHash: { > + envelope: gettext('Envelope'), > + header: gettext('Header'), > + }, > + > initComponent: function() { > var me = this; > > @@ -183,6 +188,17 @@ Ext.define('PMG.DKIMSettings', { > }, > }; > > + var render_dkimdomain = function(value) { > + return me.dkimdomainTextHash[value] || value; > + }; > + me.add_combobox_row('dkim-use-domain', gettext('Get Signing Domain From'), { > + renderer: render_dkimdomain, > + defaultValue: 'envelope', > + comboItems: [ > + ['envelope', render_dkimdomain('envelope')], > + ['header', render_dkimdomain('header')]], > + }); > + > me.add_boolean_row('dkim_sign_all_mail', gettext('Sign all Outgoing Mail')); > > var baseurl = '/config/admin';