From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.ivanov@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D2E1D94D81 for <pmg-devel@lists.proxmox.com>; Fri, 23 Feb 2024 12:20:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1B04174C7 for <pmg-devel@lists.proxmox.com>; Fri, 23 Feb 2024 12:19:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pmg-devel@lists.proxmox.com>; Fri, 23 Feb 2024 12:19:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4099944EE5 for <pmg-devel@lists.proxmox.com>; Fri, 23 Feb 2024 12:19:46 +0100 (CET) Date: Fri, 23 Feb 2024 12:19:26 +0100 From: Stoiko Ivanov <s.ivanov@proxmox.com> To: Friedrich Weber <f.weber@proxmox.com> Cc: pmg-devel@lists.proxmox.com Message-ID: <20240223121926.506b1318@rosa.proxmox.com> In-Reply-To: <68dc995a-20de-4dbc-85c6-c8be55a2b47a@proxmox.com> References: <20240222210620.362646-1-s.ivanov@proxmox.com> <68dc995a-20de-4dbc-85c6-c8be55a2b47a@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pmgdb.pm, proxmox.com] Subject: Re: [pmg-devel] [PATCH pmg-api 0/3] small improvments to pmgdb dump output X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 23 Feb 2024 11:20:17 -0000 On Fri, 23 Feb 2024 11:40:35 +0100 Friedrich Weber <f.weber@proxmox.com> wrote: > All three patches look good to me! > > * 1/3 is nice. I've also spent some time analyzing inactive rules, I'd > expect the all-caps active flag to help here. > * 2/3 is nice as well. > * 3/3 sounds potentially useful! Wouldn't pass this flag when generating > the report though, as I'd like to see active and inactive rules there. yes - I agree with that - it's something we can ask users to run explicitly in case their ruleset warrants it > > Tested-by: Friedrich Weber <f.weber@proxmox.com> > > On 22/02/2024 22:06, Stoiko Ivanov wrote: > > inspired by the patch from Dominik [0], I prepared the following patchset, > > which hopefully improves the readability of the pmgdb dump output when > > debugging. > > As these dump-tool output UX questions are quite subjective would be > > grateful for feedback from someone, who had the opportunity to use it for > > debugging. > > > > [0] https://lists.proxmox.com/pipermail/pmg-devel/2024-February/002690.html > > > > Stoiko Ivanov (3): > > pmgdb: highlight active rules > > pmgdb: drop "found" prefixes for each rule and group > > pmgdb: add active parameter to dump > > > > src/PMG/CLI/pmgdb.pm | 20 ++++++++++++++------ > > 1 file changed, 14 insertions(+), 6 deletions(-) > >