From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 72F7994B06 for ; Thu, 22 Feb 2024 22:07:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C69BF724 for ; Thu, 22 Feb 2024 22:07:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Feb 2024 22:07:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6D36744B65 for ; Thu, 22 Feb 2024 22:07:34 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Thu, 22 Feb 2024 22:07:30 +0100 Message-Id: <20240222210730.362840-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pmg-devel] [PATCH pmg-api] quarantine: userlists: sort result X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2024 21:07:35 -0000 probably just cosmetic - but I noticed it while testing the patch that fixes the sync of an empty userlist. Signed-off-by: Stoiko Ivanov --- src/PMG/Quarantine.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PMG/Quarantine.pm b/src/PMG/Quarantine.pm index e19e96f..d06a88d 100644 --- a/src/PMG/Quarantine.pm +++ b/src/PMG/Quarantine.pm @@ -59,8 +59,8 @@ sub add_to_blackwhite { } } - my $wlist = $dbh->quote(encode('UTF-8', join (',', keys %{$list->{WL}})) || ''); - my $blist = $dbh->quote(encode('UTF-8', join (',', keys %{$list->{BL}})) || ''); + my $wlist = $dbh->quote(encode('UTF-8', join (',', sort keys %{$list->{WL}})) || ''); + my $blist = $dbh->quote(encode('UTF-8', join (',', sort keys %{$list->{BL}})) || ''); if (!$delete) { my $maxlen = 200000; @@ -81,7 +81,7 @@ sub add_to_blackwhite { $dbh->do($queries); } - my $values = [ keys %{$list->{$name}} ]; + my $values = [ sort keys %{$list->{$name}} ]; return $values; } -- 2.39.2