From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7700F94878 for ; Thu, 22 Feb 2024 14:51:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5FC5C99E3 for ; Thu, 22 Feb 2024 14:51:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Feb 2024 14:51:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1CE4944B0D for ; Thu, 22 Feb 2024 14:51:20 +0100 (CET) Date: Thu, 22 Feb 2024 14:51:19 +0100 From: Stoiko Ivanov To: Thomas Lamprecht Cc: Dominik Csapak , pmg-devel@lists.proxmox.com Message-ID: <20240222145119.4357fe35@rosa.proxmox.com> In-Reply-To: <298be08f-6c2f-4c63-ae1e-f34e7dd6cc53@proxmox.com> References: <20240222091420.2732402-1-d.csapak@proxmox.com> <20240222141922.3b143b6c@rosa.proxmox.com> <298be08f-6c2f-4c63-ae1e-f34e7dd6cc53@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [PATCH pmg-gui v3 0/3] implement and combination and inversion of groups and objects X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2024 13:51:22 -0000 On Thu, 22 Feb 2024 14:26:52 +0100 Thomas Lamprecht wrote: > Am 22/02/2024 um 14:19 schrieb Stoiko Ivanov: > > FWIW: applied it locally, gave it a spin, and verified that the > > deletion-bug is gone! > > > > Thanks for the fast iteration! > > Can I assume a T-b and/or R-b from that? T-b - yes definitely R-b - my javascript-skills are usually limited to asking Dominik how to do certain thing in our gui-code - so the value of my review might be limited - but - yes - it looks good to me