From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 77E3894896 for ; Thu, 22 Feb 2024 14:19:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 603359162 for ; Thu, 22 Feb 2024 14:19:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Feb 2024 14:19:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A1E9844A7F for ; Thu, 22 Feb 2024 14:19:23 +0100 (CET) Date: Thu, 22 Feb 2024 14:19:22 +0100 From: Stoiko Ivanov To: Dominik Csapak Cc: pmg-devel@lists.proxmox.com Message-ID: <20240222141922.3b143b6c@rosa.proxmox.com> In-Reply-To: <20240222091420.2732402-1-d.csapak@proxmox.com> References: <20240222091420.2732402-1-d.csapak@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [PATCH pmg-gui v3 0/3] implement and combination and inversion of groups and objects X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2024 13:19:54 -0000 FWIW: applied it locally, gave it a spin, and verified that the deletion-bug is gone! Thanks for the fast iteration! On Thu, 22 Feb 2024 10:14:17 +0100 Dominik Csapak wrote: > since the rest got applied, the new version of the ui part > > note that patch 3 is intended to be an alternative way of handling the > update of the object list when the mode changes. so if desired can be > squashed in with patch 2 (needs then the commit message adapted) > > alternatively it can simply be left out > > changes from v2: > * left out applied patches > * added padding in the RuleInfo panel for type groupings > * fixed a bug with deletion > * incoroporated thomas' suggestions > > changes from v1: > * rebase on master > * include new tables in cluster sync + backup > * incorporate stoikos feedback > * improved commit messages > more details in the relevant patches > > changes from rfc: > * added docs + gui > * some minor bugfixes > * fixed the api (forgot to add the info to the GET calls in rfc) > * changed output for `pmgdb dump` so we get that info in the pmgreport too > > Dominik Csapak (3): > rules: use tree panel instead of grouping feature of the grid > rules/objects: add mode selector dropdown > objects: don't reload on match mode change > > css/ext6-pmg.css | 11 ++++ > js/Makefile | 1 + > js/ObjectGroup.js | 72 ++++++++++++++++++++++- > js/ObjectGroupConfiguration.js | 7 +++ > js/RuleInfo.js | 102 ++++++++++++++++++++++++++------- > js/form/MatchModeSelector.js | 11 ++++ > 6 files changed, 181 insertions(+), 23 deletions(-) > create mode 100644 js/form/MatchModeSelector.js >