From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2734394834 for ; Thu, 22 Feb 2024 14:19:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 00CAB9114 for ; Thu, 22 Feb 2024 14:18:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Feb 2024 14:18:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0797A44B14 for ; Thu, 22 Feb 2024 14:18:43 +0100 (CET) Date: Thu, 22 Feb 2024 14:18:42 +0100 From: Stoiko Ivanov To: Dominik Csapak Cc: pmg-devel@lists.proxmox.com Message-ID: <20240222141842.7946a7ae@rosa.proxmox.com> In-Reply-To: <20240222100457.3462419-1-d.csapak@proxmox.com> References: <20240222100457.3462419-1-d.csapak@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [objectgrouphelpers.pm] Subject: [pmg-devel] applied: [PATCH pmg-api] api: relaod ruledb on updating objecgroups X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2024 13:19:14 -0000 Thanks for finding and fixing this! applied the patch, with the 2 typos in the subject line fixed up, after testing it (watching the journal while sending mails before/after, looking for `pmg-smtp-filter[333766]: reloading configuration Proxmox_ruledb` ) On Thu, 22 Feb 2024 11:04:57 +0100 Dominik Csapak wrote: > previously they only contained metadata (name/comment) so for the > rulesystem that was not relevant. Now with the attributes and/invert > we want to reload the ruledb on update too. > > Signed-off-by: Dominik Csapak > --- > src/PMG/API2/ObjectGroupHelpers.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/PMG/API2/ObjectGroupHelpers.pm b/src/PMG/API2/ObjectGroupHelpers.pm > index 3060157..fabfa6a 100644 > --- a/src/PMG/API2/ObjectGroupHelpers.pm > +++ b/src/PMG/API2/ObjectGroupHelpers.pm > @@ -289,6 +289,8 @@ sub register_object_group_config_api { > > $rdb->save_group($og); > > + PMG::DBTools::reload_ruledb(); > + > return undef; > }}); > }