From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ABAB594819 for ; Thu, 22 Feb 2024 13:41:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8D0F98838 for ; Thu, 22 Feb 2024 13:41:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Feb 2024 13:41:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5004444B13 for ; Thu, 22 Feb 2024 13:41:07 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Thu, 22 Feb 2024 13:40:50 +0100 Message-Id: <20240222124051.324714-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240222124051.324714-1-s.ivanov@proxmox.com> References: <20240222124051.324714-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [backup.pm] Subject: [pmg-devel] [PATCH pmg-api 1/2] backup: reorder tables in order of dependency X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2024 12:41:38 -0000 Currently we dump the tables manually and print the relevant DDL statements into the dump-file before copying the data. The complete backup and dump specific tables part would probably be best replaced by an appropriate `pg_dump` invocation - but as a stop-gap measure reorder the tables in order of their dependencies. Noticed while adding a foreign key constraint on 2 new tables (objectgroup_attribute and rule_attribute) and running backup+restore. Reported-by: Dominik Csapak Signed-off-by: Stoiko Ivanov --- src/PMG/Backup.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PMG/Backup.pm b/src/PMG/Backup.pm index 5891afb..ab7e628 100644 --- a/src/PMG/Backup.pm +++ b/src/PMG/Backup.pm @@ -90,18 +90,18 @@ sub dumpdb { eval { $dbh->begin_work; # read a consistent snapshot $dbh->do("SET TRANSACTION ISOLATION LEVEL SERIALIZABLE"); + dump_table($dbh, 'objectgroup', $ofh, 'objectgroup_id_seq', 'id'); + dump_table($dbh, 'object', $ofh, 'object_id_seq', 'id'); dump_table($dbh, 'attribut', $ofh); dump_table($dbh, 'objectgroup_attributes', $ofh); - dump_table($dbh, 'rule_attributes', $ofh); - dump_table($dbh, 'object', $ofh, 'object_id_seq', 'id'); - dump_table($dbh, 'objectgroup', $ofh, 'objectgroup_id_seq', 'id'); dump_table($dbh, 'rule', $ofh, 'rule_id_seq', 'id'); + dump_table($dbh, 'rule_attributes', $ofh); dump_table($dbh, 'rulegroup', $ofh); dump_table($dbh, 'userprefs', $ofh); # we do not save the following tables: cgreylist, cmailstore, cmsreceivers, clusterinfo }; my $err = $@; -- 2.39.2