From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9318B93FF2 for ; Wed, 21 Feb 2024 13:25:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7CC1116C1C for ; Wed, 21 Feb 2024 13:24:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Feb 2024 13:24:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CBA2D4449D for ; Wed, 21 Feb 2024 13:24:41 +0100 (CET) From: Dominik Csapak To: pmg-devel@lists.proxmox.com Date: Wed, 21 Feb 2024 13:24:34 +0100 Message-Id: <20240221122439.1281024-9-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240221122439.1281024-1-d.csapak@proxmox.com> References: <20240221122439.1281024-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pmg-devel] [PATCH pmg-api v2 08/10] ModGroup: add possibility to explode to all targets X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2024 12:25:13 -0000 we will need that for the remove action + and/invert It's probably not the most efficient way to to that, but it's easy to understand. Signed-off-by: Dominik Csapak --- promoted to normal commit instead of WIP, since the only way i'd found to make it more 'efficient' is to copy/paste the subgroups code and instead of looping inside the innermost loop about the targets, do it on the outside, which is basically the same as we do here (but the innermost loop is always 1 long) src/PMG/ModGroup.pm | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/PMG/ModGroup.pm b/src/PMG/ModGroup.pm index b0fa9a6..d4e1cd5 100644 --- a/src/PMG/ModGroup.pm +++ b/src/PMG/ModGroup.pm @@ -81,6 +81,23 @@ sub subgroups { return $res; } +# explode the groups, so we have one for each target we need +# only to be used by the rRemove action when there was a spaminfo +sub explode { + my ($self, $targets) = @_; + + my $groups = $self->{groups}; + my $ea = $self->{ea}; + my $res; + + # TODO: implment it more direclty with less overhead! + for my $target ($targets->@*) { + $self->subgroups([$target]); + } + + return $self->subgroups($targets); +} + 1; __END__ -- 2.30.2