From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CED1590FAF for <pmg-devel@lists.proxmox.com>; Tue, 13 Feb 2024 12:30:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B287B35634 for <pmg-devel@lists.proxmox.com>; Tue, 13 Feb 2024 12:30:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pmg-devel@lists.proxmox.com>; Tue, 13 Feb 2024 12:30:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CBDA847D4E for <pmg-devel@lists.proxmox.com>; Tue, 13 Feb 2024 12:30:50 +0100 (CET) From: Dominik Csapak <d.csapak@proxmox.com> To: pmg-devel@lists.proxmox.com Date: Tue, 13 Feb 2024 12:30:48 +0100 Message-Id: <20240213113050.2349660-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [quarantine.pm] Subject: [pmg-devel] [RFC PATCH pmg-api/gui] add 'view images' checkbox to quarantine view X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 13 Feb 2024 11:30:51 -0000 so that the user can control if images should be loaded, even if the admin set that to true in the backend. I'm not completely happy with the approach, since there is currently no general way for us to see if the backend option was set, unless we'd either weaken the permissions necesary to read the config or introduce another api call that returns that info, both of which aren't optimal imho. Also we always show that checkbox now, since i didn't find a way to detect if there are images in the mail or not unless we actually load it with view images on and try to parse the email again in the frontend. Which also sound not really clean. For both reasons, sent as RFC. pmg-api: Dominik Csapak (1): api: quarantine: allow disabling images for content src/PMG/API2/Quarantine.pm | 11 +++++++++++ 1 file changed, 11 insertions(+) pmg-gui: Dominik Csapak (1): quarantine content: add checkbox for controlling image loading js/AttachmentQuarantine.js | 4 +++- js/Makefile | 1 + js/SpamQuarantine.js | 4 +++- js/VirusQuarantine.js | 4 +++- js/controller/QuarantineController.js | 19 ++++++++++++++++--- js/form/ViewImages.js | 17 +++++++++++++++++ 6 files changed, 43 insertions(+), 6 deletions(-) create mode 100644 js/form/ViewImages.js -- 2.30.2