From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B0952B40FF for ; Thu, 30 Nov 2023 13:44:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9275215E6F for ; Thu, 30 Nov 2023 13:44:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 30 Nov 2023 13:44:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D592E42CC4 for ; Thu, 30 Nov 2023 13:44:17 +0100 (CET) From: Maximiliano Sandoval To: pmg-devel@lists.proxmox.com Date: Thu, 30 Nov 2023 13:44:16 +0100 Message-Id: <20231130124416.176516-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mozilla.org] Subject: [pmg-devel] [PATCH pmg-gui] utils: escape `/` in regex for emails X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2023 12:44:19 -0000 As it is, it is valid ECMA regex but invalid in many other dialects. We escape it to make it valid in, say PCRE2. Note that `/` marks the end of the regex [1], hence Some@example@oh\no@ is valid according to this regex if we do not escape `/`. [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Regular_expressions/Character_escape Signed-off-by: Maximiliano Sandoval --- Fun fact: This was detected by xgettext while doing tests extracting strings for translations. js/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/Utils.js b/js/Utils.js index 7fa154e..8974cb9 100644 --- a/js/Utils.js +++ b/js/Utils.js @@ -903,7 +903,7 @@ Ext.define('PMG.Async', { Ext.apply(Ext.form.field.VTypes, { // matches the pmg-email-address in pmg-api PMGMail: function(v) { - return (/[^\s\\@]+@[^\s/\\@]+/).test(v); + return (/[^\s\\@]+@[^\s\/\\@]+/).test(v); }, PMGMailText: gettext('Example') + ": user@example.com", }); -- 2.39.2