From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2251BB946 for ; Tue, 12 Sep 2023 16:22:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0400613AA8 for ; Tue, 12 Sep 2023 16:22:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 12 Sep 2023 16:22:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BC70545FDB for ; Tue, 12 Sep 2023 16:22:55 +0200 (CEST) Date: Tue, 12 Sep 2023 16:22:54 +0200 From: Stoiko Ivanov To: Maximiliano Sandoval Cc: pmg-devel@lists.proxmox.com Message-ID: <20230912162254.1956be7b@rosa.proxmox.com> In-Reply-To: <20230907134704.164144-2-m.sandoval@proxmox.com> References: <20230907134704.164144-1-m.sandoval@proxmox.com> <20230907134704.164144-2-m.sandoval@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pmg-devel] [PATCH pmg-gui 2/2] mail-proxy-relaying: add help to Default Relay X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2023 14:22:57 -0000 Thanks for the addition - LGTM in general. One question remains - why only add it here and not also the the other editors (port, protocol, nomx)? On Thu, 7 Sep 2023 15:47:04 +0200 Maximiliano Sandoval wrote: > Add link to [1]. This is quite an important setting, might as well > provide documentation. > > [1] https://pmg.proxmox.com/pmg-docs/chapter-pmgconfig.html#pmgconfig_mailproxy_relaying > > Signed-off-by: Maximiliano Sandoval > --- > js/MailProxyRelaying.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/js/MailProxyRelaying.js b/js/MailProxyRelaying.js > index 411c9b4..c9fafbe 100644 > --- a/js/MailProxyRelaying.js > +++ b/js/MailProxyRelaying.js > @@ -10,6 +10,7 @@ Ext.define('PMG.MailProxyRelaying', { > me.add_text_row('relay', gettext('Default Relay'), { > deleteEmpty: true, > defaultValue: Proxmox.Utils.noneText, > + onlineHelp: 'pmgconfig_mailproxy_relaying', > }); > > me.add_integer_row('relayport', gettext('Relay Port'), {