From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.ivanov@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9594EB93D for <pmg-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:18:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 70A3F13981 for <pmg-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:18:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pmg-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:18:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DF76A45FC7 for <pmg-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:18:20 +0200 (CEST) Date: Tue, 12 Sep 2023 16:18:19 +0200 From: Stoiko Ivanov <s.ivanov@proxmox.com> To: Dominik Csapak <d.csapak@proxmox.com> Cc: Mira Limbeck <m.limbeck@proxmox.com>, pmg-devel@lists.proxmox.com Message-ID: <20230912161819.6aac2b81@rosa.proxmox.com> In-Reply-To: <b0c7d8e1-ff72-481f-9786-89c6f4d4ce2f@proxmox.com> References: <20230719151352.1438974-1-m.limbeck@proxmox.com> <b0c7d8e1-ff72-481f-9786-89c6f4d4ce2f@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH log-tracker 1/2] add clamd signature found messages to log output X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 12 Sep 2023 14:18:53 -0000 hi, On Fri, 4 Aug 2023 14:09:32 +0200 Dominik Csapak <d.csapak@proxmox.com> wrote: > hi, > > in general it works and does what is says, > but after looking at the log tracker output, i'm nto sure if it's worth > it. we log the same info directly after that from the pmg-smtp-filter... > > otoh, the code is not that big and probably doesn't hurt either > > @stoiko, maybe you have some input on that? hm - a bit ambivalent on this: * on the one hand - having more information, which is useful for most common setups (only ClamAV is used) might help * on the other hand - if we have exactly the same information (which virus was detected, and by which engine one line below I don't see the benefit of adding more lines) Currently I'd rather not apply it - but I'm not too set on this either. > > in any case, consider both patches > > Reviewed-by: Dominik Csapak <d.csapak@proxmox.com> > Tested-by: Dominik Csapak <d.csapak@proxmox.com> > > > > > _______________________________________________ > pmg-devel mailing list > pmg-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel > >