From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <s.ivanov@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 3BFE2B981
for <pmg-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:16:02 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 1DE801393F
for <pmg-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:15:32 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pmg-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:15:28 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 08F3745FA2
for <pmg-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:15:28 +0200 (CEST)
Date: Tue, 12 Sep 2023 16:15:26 +0200
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Message-ID: <20230912161526.77438010@rosa.proxmox.com>
In-Reply-To: <pkimml6akmnfcsvb437xgcf33dvsvqgjgowizt6rla3mma6fcz@luuk36saz3dk>
References: <20230809100739.423147-1-c.heiss@proxmox.com>
<pkimml6akmnfcsvb437xgcf33dvsvqgjgowizt6rla3mma6fcz@luuk36saz3dk>
X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.312 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible
spam tricks
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com]
Subject: Re: [pmg-devel] [PATCH pmg-gui] css: fix icon/text alignment in
panel headers for Firefox
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
<pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 12 Sep 2023 14:16:02 -0000
sorry for replying so late
* managed to reproduce it in firefox 102.15.0esr (version in bookworm)
* the patch fixes it for the pmg-gui
* Regarding your question if a fix is better done in pwt or a separate fix
for proxmox-backup would be better I think Dominik or Thomas might have
better ideas/suggestions
in any case - consider this:
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
On Wed, 9 Aug 2023 16:33:43 +0200
Christoph Heiss <c.heiss@proxmox.com> wrote:
> Just noticed this is broken in PBS as well.
> I guess it should be then fixed in proxmox-widget-toolkit directly? Or
> rather separately?
>
> On Wed, Aug 09, 2023 at 12:07:37PM +0200, Christoph Heiss wrote:
> >
> > Add `vertial-align: text-top` to all panel header icons - for the
> > accompanying text, this already gets set through the `.x-tab-inner`
> > class.
> >
> > Without this, in Firefox (116.0.1, at least) the icon and the text would
> > be slightly offset vertically - due to different baselines, I'd guess.
> > Chromium seems fine w/ and w/o the patch, no change there.
> >
> > Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> > ---
> > css/ext6-pmg.css | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/css/ext6-pmg.css b/css/ext6-pmg.css
> > index 2f999f4..68e5b7a 100644
> > --- a/css/ext6-pmg.css
> > +++ b/css/ext6-pmg.css
> > @@ -180,6 +180,10 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled {
> > height: initial;
> > }
> >
> > +.x-tab-icon-el {
> > + vertical-align: text-top;
> > +}
> > +
> > tr.x-grid-row-summary td.x-grid-cell {
> > border-top: 1px solid black;
> > font-weight: bold;
> > --
> > 2.41.0
> >
> >
> >
> > _______________________________________________
> > pmg-devel mailing list
> > pmg-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
> >
> >
>
>
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
>
>