From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 390419DC9 for ; Wed, 6 Sep 2023 15:09:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2260233E43 for ; Wed, 6 Sep 2023 15:09:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Sep 2023 15:09:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 70AB842B19 for ; Wed, 6 Sep 2023 15:09:11 +0200 (CEST) From: Maximiliano Sandoval To: pmg-devel@lists.proxmox.com Date: Wed, 6 Sep 2023 15:09:07 +0200 Message-Id: <20230906130907.2036832-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2023 13:09:13 -0000 >From a UX perspective flat buttons, i.e. buttons without a frame or background, are not obviously clickable without an icon. The choice of icons was taken from pve-manager's Utils.js module. Signed-off-by: Maximiliano Sandoval --- Differences from v2: - Use folder icon as suggest in v2 of the patch - Improved commit message js/BackupConfiguration.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/js/BackupConfiguration.js b/js/BackupConfiguration.js index e21771f..ed9959c 100644 --- a/js/BackupConfiguration.js +++ b/js/BackupConfiguration.js @@ -12,11 +12,13 @@ Ext.define('PMG.BackupConfiguration', { itemId: 'local', title: gettext('Local Backup/Restore'), xtype: 'pmgBackupRestore', + iconCls: 'fa fa-folder', }, { itemId: 'proxmoxbackupserver', title: 'Proxmox Backup Server', xtype: 'pmgPBSConfig', + iconCls: 'fa fa-floppy-o', }, ], }); -- 2.39.2